Repository navigation
Conversation
govulncheck reports vulnerabilities that rpc's code can reach in golang.org/x/net v0.58.0, github.com/klauspost/compress v1.18.1 and github.com/go-chi/chi v4.1.2, and chi has no fixed v4 release. This pins the go-stellar-sdk commit of stellar/go-stellar-sdk#6048, which moves the SDK to x/net v0.60.0, klauspost/compress v1.20.2 and chi v5. supporthttp.NewMux now returns a chi v5 router, so rpc's chi imports move to github.com/go-chi/chi/v5 too. The other go.mod bumps are the versions the new SDK requires. chi v5's Recoverer answers a panicking handler with a 500, where chi v4's panicked while printing the stack and the server dropped the connection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
govulncheck reports seven vulnerabilities that stellar-rpc's code can reach. Five are in golang.org/x/net v0.58.0 (GO-2026-6617, GO-2026-6612, GO-2026-6611, GO-2026-6610 and GO-2026-6603), one is in github.com/klauspost/compress v1.18.1 (GO-2026-6865) and one is in github.com/go-chi/chi v4.1.2 (GO-2026-4316). chi has no fixed v4 release, so stellar-rpc has to move to chi v5.
This PR pins go-stellar-sdk to the commit of stellar/go-stellar-sdk#6048, which moves the SDK to x/net v0.60.0, klauspost/compress v1.20.2 and chi v5. The pin will move to that PR's commit on the SDK's main branch once it merges. Because
supporthttp.NewMuxnow returns a chi v5 router, the two chi imports incmd/stellar-rpc/internal/jsonrpcmove togithub.com/go-chi/chi/v5. The other go.mod bumps are the versions the new SDK requires. With this change,govulncheck ./...prints "No vulnerabilities found."The only behavior change is on the admin endpoint. A handler that panics there now gets a 500 response, where chi v4's
Recovererpanicked while printing the stack and the server dropped the connection. The JSON-RPC bridge recovers its own panics, so JSON-RPC responses do not change. The admin routes and the route patterns in the request logs also stay the same.🤖 Generated with Claude Code