Skip to content

Bump go-stellar-sdk and move to chi v5 to fix vulnerable dependencies - #1195

Open
tamirms wants to merge 1 commit into
mainfrom
bump-vulnerable-deps
Open

tamirms wants to merge 1 commit into
mainfrom
bump-vulnerable-deps

Conversation

@tamirms

@tamirms tamirms commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

govulncheck reports seven vulnerabilities that stellar-rpc's code can reach. Five are in golang.org/x/net v0.58.0 (GO-2026-6617, GO-2026-6612, GO-2026-6611, GO-2026-6610 and GO-2026-6603), one is in github.com/klauspost/compress v1.18.1 (GO-2026-6865) and one is in github.com/go-chi/chi v4.1.2 (GO-2026-4316). chi has no fixed v4 release, so stellar-rpc has to move to chi v5.

This PR pins go-stellar-sdk to the commit of stellar/go-stellar-sdk#6048, which moves the SDK to x/net v0.60.0, klauspost/compress v1.20.2 and chi v5. The pin will move to that PR's commit on the SDK's main branch once it merges. Because supporthttp.NewMux now returns a chi v5 router, the two chi imports in cmd/stellar-rpc/internal/jsonrpc move to github.com/go-chi/chi/v5. The other go.mod bumps are the versions the new SDK requires. With this change, govulncheck ./... prints "No vulnerabilities found."

The only behavior change is on the admin endpoint. A handler that panics there now gets a 500 response, where chi v4's Recoverer panicked while printing the stack and the server dropped the connection. The JSON-RPC bridge recovers its own panics, so JSON-RPC responses do not change. The admin routes and the route patterns in the request logs also stay the same.

🤖 Generated with Claude Code

govulncheck reports vulnerabilities that rpc's code can reach in
golang.org/x/net v0.58.0, github.com/klauspost/compress v1.18.1 and
github.com/go-chi/chi v4.1.2, and chi has no fixed v4 release.

This pins the go-stellar-sdk commit of stellar/go-stellar-sdk#6048,
which moves the SDK to x/net v0.60.0, klauspost/compress v1.20.2 and
chi v5. supporthttp.NewMux now returns a chi v5 router, so rpc's chi
imports move to github.com/go-chi/chi/v5 too. The other go.mod bumps
are the versions the new SDK requires.

chi v5's Recoverer answers a panicking handler with a 500, where chi
v4's panicked while printing the stack and the server dropped the
connection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant