Skip to content

Use the go.mod toolchain line as the one Go version for every build - #1194

Open
tamirms wants to merge 1 commit into
mainfrom
go-toolchain
Open

tamirms wants to merge 1 commit into
mainfrom
go-toolchain

Conversation

@tamirms

@tamirms tamirms commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Each build path picked its own Go version: the setup-go action defaulted to 1.26, CodeQL pinned 1.26, the Dockerfile defaulted to 1.26.9, and the perf-eval boxes installed 1.26.5. So the Go version in a release depended on which path built it.

This adds toolchain go1.26.11, the latest Go 1.26 release, to go.mod and makes every build read it. The go 1.26.0 line is unchanged.

  • The setup-go action reads the version from go.mod and no longer takes a go-version input, so a workflow cannot pin its own. Its build cache key uses the version it installed.
  • CodeQL no longer passes go-version: 1.26.
  • The Dockerfile's GO_VERSION build argument has no default, and the build stops right away when it is missing. Nothing in this repository builds that Dockerfile; the package builder that does is being changed to pass the go.mod version, and that change must merge first.
  • The perf-eval boxes install the Go version named by the checked-out go.mod, so go-bench builds the baseline and the candidate with the same Go.

🤖 Generated with Claude Code

Each build chose its own Go version: the setup-go action defaulted to
1.26, CodeQL pinned 1.26, the Dockerfile defaulted to 1.26.9 and the
perf-eval boxes installed 1.26.5. Which Go a release was built with
depended on which path built it.

go.mod now has a toolchain line, go1.26.11, and every build reads it.
The setup-go action takes the version from go.mod, has no go-version
input to override it, and keys its build cache by the resolved version.
The Dockerfile's GO_VERSION has no default and the build stops at once
without it. The perf-eval box installs the version named by the
checked-out go.mod.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant