Repository navigation
Conversation
Each build chose its own Go version: the setup-go action defaulted to 1.26, CodeQL pinned 1.26, the Dockerfile defaulted to 1.26.9 and the perf-eval boxes installed 1.26.5. Which Go a release was built with depended on which path built it. go.mod now has a toolchain line, go1.26.11, and every build reads it. The setup-go action takes the version from go.mod, has no go-version input to override it, and keys its build cache by the resolved version. The Dockerfile's GO_VERSION has no default and the build stops at once without it. The perf-eval box installs the version named by the checked-out go.mod. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each build path picked its own Go version: the setup-go action defaulted to 1.26, CodeQL pinned 1.26, the Dockerfile defaulted to 1.26.9, and the perf-eval boxes installed 1.26.5. So the Go version in a release depended on which path built it.
This adds
toolchain go1.26.11, the latest Go 1.26 release, to go.mod and makes every build read it. Thego 1.26.0line is unchanged.go-versioninput, so a workflow cannot pin its own. Its build cache key uses the version it installed.go-version: 1.26.GO_VERSIONbuild argument has no default, and the build stops right away when it is missing. Nothing in this repository builds that Dockerfile; the package builder that does is being changed to pass the go.mod version, and that change must merge first.🤖 Generated with Claude Code