Repository navigation
rpcv2: align captive core meta flags with Galexie's - #1193
Merged
Merged
Conversation
cjonas9
marked this pull request as ready for review
November 13, 2026 19:00
tamirms
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1165.
What
RPC archive node now runs captive core with
EmitVerboseMeta, the same setting galexie uses to write the data lake that RPC backfills from. That newly turns onEMIT_LEDGER_CLOSE_META_EXT_V1andBACKFILL_STELLAR_ASSET_EVENTS. The flags v2 already set stay on.Why
Ledger packs store meta exactly as core emits it, so a ledger ingested live from RPCv2's captive core had different bytes from the same ledger backfilled from the lake. Sharing galexie's setting keeps the two in step, which will be useful post-GA for data sharing. If they want to, an operator can still turn a flag off in their captive-core file.
Testing
Ran this change on a live pubnet RPC v2 archive node (core 30.0.0, protocol 29):
EMIT_LEDGER_CLOSE_META_EXT_V1 = trueandBACKFILL_STELLAR_ASSET_EVENTS = true.LedgerCloseMetav1 extension. Those sampled against the data lake match its copy in fee value and length.Note that the node ran this diff on top of
25c2eb0crather than this branch, because its data predates #1082's index format change, though this should not be of any functional consequence.Known limitations
This doesn't change that live and lake ledgers differ in several non-deterministic fields (e.g.
invoke_time_nsecswithin diagnostic events). Future work requiring determinism between ledger data should exclude such fields from verification.🤖 Generated with Claude Code