Skip to content

Add a workflow that syncs testnet_settings_upgrade.json with testnet - #5512

Queued
sisuresh wants to merge 3 commits into
stellar:masterfrom
sisuresh:soroban-settings-sync
Queued

sisuresh wants to merge 3 commits into
stellar:masterfrom
sisuresh:soroban-settings-sync

Conversation

@sisuresh

@sisuresh sisuresh commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Adds a daily workflow that reads testnet's live upgradeable Soroban settings over RPC and opens a PR updating soroban-settings/testnet_settings_upgrade.json when they differ, so the file stays applicable after network resets as protocol and settings upgrades land. Non-upgradeable settings are read from SorobanNetworkConfig::isNonUpgradeableConfigSettingEntry, and the script fails rather than writing a partial file when anything doesn't line up.

Example run in my fork - sisuresh#29

Daily, reads testnet's live upgradeable Soroban settings over RPC and opens or
updates a PR when the file differs, closing it if testnet matches again.
Copilot AI balanced review requested due to automatic review settings November 17, 2026 22:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the Soroban settings synchronization change.

No open issues 🎉

What changed in this PR

Adds automation to keep Stellar Core’s testnet Soroban upgrade settings aligned with the live network, helping preserve applicable settings across network resets and protocol upgrades.

Changes:

  • Adds a script that reads live settings, excludes non-upgradeable entries, and validates the result before updating the JSON file.
  • Adds a daily and manually triggered workflow that manages sync PRs and sends deduplicated Slack failure notifications.
  • Documents the script’s prerequisites and usage.
File Description
scripts/​sync-soroban-settings.sh Fetches, validates, and writes testnet’s upgradeable Soroban settings.
scripts/​README.md Documents the sync script and its automated workflow.
.github/​workflows/​soroban-settings-sync.yml Schedules synchronization, manages PRs, and reports failures.

Review effort: Balanced

@sisuresh
sisuresh requested a review from anupsdf November 17, 2026 22:13
Uses SLACK_BOT_TOKEN via slackapi/slack-github-action, as other stellar repos
do, instead of an incoming webhook.
@sisuresh
sisuresh added this pull request to the merge queue Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants