Repository navigation
Conversation
Daily, reads testnet's live upgradeable Soroban settings over RPC and opens or updates a PR when the file differs, closing it if testnet matches again.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the Soroban settings synchronization change.
No open issues 🎉
What changed in this PR
Adds automation to keep Stellar Core’s testnet Soroban upgrade settings aligned with the live network, helping preserve applicable settings across network resets and protocol upgrades.
Changes:
- Adds a script that reads live settings, excludes non-upgradeable entries, and validates the result before updating the JSON file.
- Adds a daily and manually triggered workflow that manages sync PRs and sends deduplicated Slack failure notifications.
- Documents the script’s prerequisites and usage.
| File | Description |
|---|---|
scripts/sync-soroban-settings.sh |
Fetches, validates, and writes testnet’s upgradeable Soroban settings. |
scripts/README.md |
Documents the sync script and its automated workflow. |
.github/workflows/soroban-settings-sync.yml |
Schedules synchronization, manages PRs, and reports failures. |
Review effort: Balanced
Uses SLACK_BOT_TOKEN via slackapi/slack-github-action, as other stellar repos do, instead of an incoming webhook.
anupsdf
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a daily workflow that reads testnet's live upgradeable Soroban settings over RPC and opens a PR updating
soroban-settings/testnet_settings_upgrade.jsonwhen they differ, so the file stays applicable after network resets as protocol and settings upgrades land. Non-upgradeable settings are read fromSorobanNetworkConfig::isNonUpgradeableConfigSettingEntry, and the script fails rather than writing a partial file when anything doesn't line up.Example run in my fork - sisuresh#29