Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
173 commits
Select commit Hold shift + click to select a range
693c4b8
add socket tier 1 reachability analysis
kanwalpreetd Jun 29, 2026
1a724c3
Fail noisily if an unknown --enable or --disable flag is passed to co…
graydon Jul 29, 2026
ae477f0
Run horizon tests in core on PR and push
Shaptic Jul 7, 2026
c6e2db7
Merge branch 'master' into call-hz-tests
Shaptic Jul 30, 2026
9ced1fa
Merge branch 'master' into call-hz-tests
sisuresh Aug 3, 2026
53be922
Run Horizon integration tests with Core compiled from source (#5340)
sisuresh Aug 3, 2026
4c016bb
Add new mode to apply load for tx set validation
SirTyson Aug 4, 2026
0d3f561
wip
graydon Aug 5, 2026
dc4467c
loosen process limit
graydon Aug 5, 2026
a9b8613
loosen process limit (#5406)
sisuresh Aug 5, 2026
81f34ab
Various memory-measuring improvements
graydon Aug 7, 2026
2ac4eaa
Harden TCPPeer tests, fix flakiness
marta-lokhova Aug 10, 2026
b6a2ac8
Bring back medida::Timer now that CKMS compression is much faster
marta-lokhova Aug 11, 2026
f951722
Harden TCPPeer tests, fix flakiness (#5410)
marta-lokhova Aug 11, 2026
976ae48
Bring back medida::Timer now that CKMS compression is much faster (#5…
marta-lokhova Aug 12, 2026
9edab5b
Cleanup
SirTyson Aug 13, 2026
13758a2
Deduplicate query messages
graydon Aug 11, 2026
af933c1
Skip background tx sig verification for unauthenticated peers
bboston7 Aug 13, 2026
6fe13a4
Fix flaky survey test
marta-lokhova Aug 11, 2026
50e4284
Fix flaky survey test (#5413)
marta-lokhova Aug 14, 2026
100cc38
Add new mode to apply load for tx set validation (#5404)
SirTyson Aug 14, 2026
dd62ae8
Destroy parallel apply state asynchronously.
dmkozh Aug 10, 2026
c246a5f
Extract entries by reference from LTX.
dmkozh Aug 7, 2026
bcb1371
Clamp additions in tx set fee summing functions
bboston7 Aug 14, 2026
50a9737
Merge pull request #705 from stellar/dedupe-query-messages
graydon Aug 14, 2026
a275344
Merge pull request #706 from stellar/pre-auth-sig
graydon Aug 14, 2026
947aad8
Merge pull request #710 from stellar/cc-overflow
graydon Aug 14, 2026
31648e6
Merge branch 'master' into master
kanwalpreetd Aug 20, 2026
2912ba4
Deprecate banned accounts functionality now that CAP-0077 is active
marta-lokhova Aug 21, 2026
e17414f
socket-scan: address review comments
kanwalpreetd Aug 21, 2026
c347dc0
socket-scan: drop the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var
kanwalpreetd Aug 21, 2026
68a3c8f
Clarify backgound ledger apply flow invariants
marta-lokhova Aug 26, 2026
11f38d3
parallel application flow: renames for clarity
marta-lokhova Aug 26, 2026
dee3b7e
Add support for tracy-import-chrome tool
graydon Apr 22, 2026
a3bf440
Fix timing issue in tests
marta-lokhova Aug 27, 2026
f59ad6b
Deprecate banned accounts functionality now that CAP-0077 is active (…
marta-lokhova Aug 27, 2026
bf391bb
Merge branch 'master' into master
kanwalpreetd Aug 28, 2026
9020c27
Clarify background ledger apply flow in comments and rename some vari…
marta-lokhova Aug 28, 2026
7791bbe
add socket tier 1 reachability analysis (#5333)
kanwalpreetd Aug 28, 2026
655e83e
Skip the Horizon and RPC integration tests on the private repo
sisuresh Aug 28, 2026
0752b51
Skip the Horizon and RPC integration tests on the private repo (#5433)
sisuresh Aug 28, 2026
48087e3
Fix reace condition is SnapshotStressTest
SirTyson Aug 31, 2026
b25aabe
Fix reace condition is SnapshotStressTest (#5438)
SirTyson Aug 31, 2026
2913af6
merge release/28.0.1-internal to master (#5440)
graydon Sep 2, 2026
42ac1e1
Fix fastdev divergence bug
graydon Aug 19, 2026
74cfcec
Tweak to deal with ENABLE_FUZZ, fix configure flag in build-fuzz, fix…
graydon Aug 22, 2026
c17475e
Propagate user RUSTFLAGS and fix fuzz RUSTFLAGS
graydon Sep 4, 2026
2237479
Update the contribution guildline to stellar-core for external contri…
anupsdf Sep 4, 2026
7e64393
Update the contribution guideline in stellar-core for external contri…
anupsdf Sep 5, 2026
457f20b
Fix fastdev divergence bug (#5420)
graydon Sep 9, 2026
1779711
Destroy parallel apply state asynchronously. (#5414)
dmkozh Sep 11, 2026
773beae
Add txset construction mode to apply load
SirTyson Sep 8, 2026
7528e49
Update background signature test to use new overlay test helpers
bboston7 Sep 16, 2026
052daf3
Parallelize Soroban pre-apply step.
dmkozh Aug 3, 2026
6ede7be
Parallelize Soroban pre-apply step. (#5402)
dmkozh Sep 16, 2026
6d05545
Fail noisily if an unknown --enable or --disable flag is passed to co…
graydon Sep 17, 2026
98c3040
Update background signature test to use new overlay test helpers (#5456)
dmkozh Sep 17, 2026
4238712
Add txset construction mode to apply load (#5448)
SirTyson Sep 17, 2026
48a451d
Extract entries by reference from LTX. (#5411)
graydon Sep 17, 2026
18aaf19
Tcmalloc fixes (#5407)
graydon Sep 17, 2026
d12b318
Tracy import chrome (#5242)
graydon Sep 18, 2026
d52c5fc
Fix configure unknown --enable-foo detection bug caused by recursive …
graydon Sep 18, 2026
bb32c8a
Make Soroban metric batching code lock-free.
dmkozh Aug 26, 2026
7666139
Improve `applyCheck` and `TestAccount` test utilites.
dmkozh Sep 18, 2026
a4a8a6a
Update tx meta
dmkozh Sep 3, 2026
7b17236
pass -g1 to limit memory pressure during CI
graydon Sep 18, 2026
8917e6a
pass -g1 to limit memory pressure during CI (#5465)
anupsdf Sep 19, 2026
5587daf
Make Soroban metric batching code lock-free. (#5436)
graydon Sep 19, 2026
9813166
Fix configure unknown --enable-foo detection bug caused by recursive …
graydon Sep 21, 2026
e1085a8
Improve `applyCheck` and `TestAccount` test utilites. (#5439)
dmkozh Sep 21, 2026
b1ec779
Add --check-lcm mode to verify captured LedgerCloseMeta golden data i…
sisuresh Sep 3, 2026
9c7a710
Fix duplicate test section names that collide in LCM capture
sisuresh Sep 3, 2026
4d150f8
Fail --check-lcm when a golden file exists but the test produces no meta
sisuresh Sep 3, 2026
0241563
Derive test NODE_SEED from the logical instance number in LCM runs
sisuresh Sep 3, 2026
4ed2168
Fix stale docs on LCM normalization and accumulation
sisuresh Sep 3, 2026
50fd4e6
Prune stale golden LCM data on capture
sisuresh Sep 3, 2026
14dac21
Skip LCM capture for tests whose meta cannot be golden data
sisuresh Sep 3, 2026
df73d53
Fix index handling and directory coverage in LCM capture finalization
sisuresh Sep 3, 2026
953bb8e
Document the LedgerCloseMeta checks in CONTRIBUTING.md
sisuresh Sep 3, 2026
abe1c55
Regenerate and prune the captured LedgerCloseMeta golden data
sisuresh Sep 3, 2026
4089bd4
Address review: rename disableLcmCapture, raw index names, path handling
sisuresh Sep 18, 2026
56ee911
Rename LedgerCloseMeta golden files for the raw index name format
sisuresh Sep 18, 2026
e291044
Regenerate LedgerCloseMeta golden data after merging master
sisuresh Sep 18, 2026
8815ef1
Make LCM capture always rebuild visited directories; drop the reason …
sisuresh Sep 18, 2026
47f773e
Scope disableLcmCapture to the current leaf section
sisuresh Sep 22, 2026
e2f0e77
Regenerate LedgerCloseMeta golden data after rebasing onto master
sisuresh Sep 22, 2026
8606538
Only record or check LCM goldens for runs that passed
sisuresh Sep 22, 2026
1b9d421
Add --check-lcm mode to verify captured LedgerCloseMeta golden data i…
sisuresh Sep 25, 2026
c707bac
Run Horizon integration tests at protocol 28
sisuresh Sep 22, 2026
1a5e2f8
Protocol 30 (CAP-0084): muxed contract addresses
sisuresh Sep 28, 2026
388a5f3
Render muxed addresses as strkeys in xdrquery
sisuresh Sep 28, 2026
387990e
Regenerate tx-meta baselines and LedgerCloseMeta golden data
sisuresh Sep 28, 2026
abf653d
Address review feedback
sisuresh Sep 29, 2026
73f2bdd
Protocol 30 (CAP-0084) (#5472)
sisuresh Sep 29, 2026
cf8f96d
Run Horizon integration tests at protocol 28 (#5469)
sisuresh Sep 29, 2026
ef19e40
Improve DEX offer crossing accuracy.
dmkozh Aug 27, 2026
166dbac
Bump protocol version to 29
sisuresh Sep 1, 2026
86e1af7
Exempt pool hops from the offer crossing limit starting in protocol 29
sisuresh Aug 31, 2026
1d258b1
Bump env to internal v29
sisuresh Sep 4, 2026
ae91765
Update tests for the protocol 29 Wasm cost inputs
sisuresh Sep 4, 2026
43805cc
Re-record the current TxMeta baseline for the p29 cost inputs
sisuresh Sep 4, 2026
c22aea0
Drop the protocol 29 cost input comments from the tests
sisuresh Sep 4, 2026
7ce6bb4
Address review feedback on the protocol 29 test updates
sisuresh Sep 4, 2026
0bc0765
Regenerate the protocol 29 ledger-close-meta reference files
sisuresh Sep 4, 2026
fcb2ef6
Remove hash-of-hash optimization.
dmkozh Sep 4, 2026
54817bf
Drop over-limit messages early (#730)
bboston7 Sep 8, 2026
06272b9
Harden outbound queue load shedding
marta-lokhova Sep 4, 2026
8e2f21a
Don't read messages during auth handshake
SirTyson Sep 10, 2026
0d50961
Lower max message size in protocol 29 (#733)
bboston7 Sep 15, 2026
ec9001a
Resolve merge conflicts and update Cargo.lock for the p29 env pin at …
anupsdf Oct 1, 2026
144cfb0
Skip Stellar-contract-spec.x in the Rust XDR identity check
sisuresh Oct 1, 2026
9ea57b8
Pin the quorum analyzer to the p29 XDR
sisuresh Oct 1, 2026
c4b5fcb
Bump the p30 Soroban host to fddfd567 (v29.0.0 merged into main)
anupsdf Oct 2, 2026
c1b8012
Regenerate TxMeta and LCM golden data for protocol 29 and 30
anupsdf Oct 2, 2026
88d2431
Merge v29.0.0 to master (#5476)
anupsdf Oct 2, 2026
f0e6dc4
add security notes for stellar-core v28.0.0
anupsdf Sep 1, 2026
9568005
add security notes for stellar-core v28.0.0 through v29.0.0 releases …
anupsdf Oct 7, 2026
9310073
Bump to protocol 30 and ungate CAP-0084 and CAP-0087
sisuresh Oct 8, 2026
443f978
Add protocol 30 tests for CAP-0084 and CAP-0087
sisuresh Oct 8, 2026
09f7d11
Re-record TxMeta baselines, LCM golden data and LCM reference files
sisuresh Oct 8, 2026
b3c226b
Bump Overlay max version in prep for protocol 30
anupsdf Oct 8, 2026
4e2c208
Bump to protocol 30 and ungate CAP-0084 and CAP-0087 (#5478)
sisuresh Oct 9, 2026
ba6a4e6
Bump Overlay min and max version in prep for protocol 30 (#5483)
anupsdf Oct 9, 2026
733b60a
Bump p30 Soroban host to the rs-soroban-env 30.0.0 release
sisuresh Oct 9, 2026
56faf50
Add ms component to StellarValue
SirTyson Aug 20, 2026
dfd6d9c
Fix more sub-second ledger edge cases
SirTyson Aug 21, 2026
9c3f33a
Convert closeTimeMs to unix time in ms
SirTyson Aug 27, 2026
acd945d
Change time type to TimePointMs
SirTyson Oct 5, 2026
36fa0b7
Remove MS_CLOSE_TIME ifdef
SirTyson Oct 6, 2026
6f289c3
Repin p30 Soroban host to pick up crates.io soroban-wasmi
sisuresh Oct 9, 2026
c4a143c
Bump p30 Soroban host to the rs-soroban-env 30.0.0 release (#5484)
sisuresh Oct 9, 2026
df6ef01
Millisecond-resolution close times (MS_CLOSE_TIME, vnext) (#5423)
SirTyson Oct 9, 2026
c285b15
Harden tx set checks
SirTyson Oct 7, 2026
0e49751
Tx set validity hardening (#5481)
SirTyson Oct 9, 2026
7a8064c
Fix flaky test by making test-only flow control-bypass explicit
graydon Oct 8, 2026
c6be764
different workaround to stuck-configure bug in #5462
graydon Oct 8, 2026
20606d7
fix flaky "ledger state update flow with parallel apply" test
graydon Oct 9, 2026
66defff
Fix flaky tests (#5482)
graydon Oct 13, 2026
47a40f3
Add workflow that opens a PR bumping the min overlay version
sisuresh Oct 14, 2026
dbe95a7
Simplify the ledger view hierarchy and interfaces.
dmkozh Oct 12, 2026
983b948
Simplify the ledger view hierarchy and interfaces. (#5461)
dmkozh Oct 14, 2026
fb5c4d3
Add CI check that protocol bumps come with an overlay version bump
sisuresh Oct 14, 2026
b46d35c
Pass encoded Soroban changes to C++ in strict footprint order.
dmkozh Aug 19, 2026
c7f52d6
Add CI check that protocol bumps come with an overlay version bump (#…
sisuresh Oct 15, 2026
c4adb73
Select releases by tag major version in check-overlay-min-version.sh
sisuresh Oct 15, 2026
6039088
Pass encoded Soroban changes to C++ in strict footprint order. (#5421)
dmkozh Oct 15, 2026
4b7697e
Add workflow that opens a PR bumping the min overlay version (#5475)
sisuresh Oct 16, 2026
b8ce5cf
Parallelize merge of per-thread changes into global map.
dmkozh Oct 16, 2026
52cc839
Parallelize merge of per-thread changes into global map. (#5415)
dmkozh Oct 19, 2026
8ccf3c9
fix flaky TCPPeer test
graydon Oct 17, 2026
48c11a6
Optimizations for Soroban LTX commit path.
graydon Oct 21, 2026
b5701f4
Optimizations for Soroban LTX commit path. (#5418)
dmkozh Oct 21, 2026
05c6328
fix flaky TCPPeer test (#5488)
dmkozh Oct 22, 2026
deef124
Shard verifySig cache to reduce mutex contention.
dmkozh Oct 15, 2026
89c4fc6
Fix flaky test
dmkozh Oct 27, 2026
b8c4f12
Shard verifySig cache to reduce mutex contention. (#5286)
dmkozh Oct 27, 2026
15101ad
add process.memory.malloc-heap metric
graydon Nov 2, 2026
a1f4383
add process.memory.malloc-heap metric (#5491)
graydon Nov 3, 2026
97951ff
Run the RPC and Horizon integration tests at core's next protocol
sisuresh Oct 2, 2026
362dbc5
Run the RPC and Horizon integration tests at core's next protocol (#5…
sisuresh Nov 5, 2026
af2c821
Merge master (362dbc518) into overlay-v2-shared
SirTyson Nov 9, 2026
3b496b7
overlay: decode protocol 30 XDR with stellar-xdr 30.0.0
SirTyson Nov 9, 2026
fe5eefb
Adapt overlay v2 herder tests to millisecond close times
SirTyson Nov 9, 2026
04fbddb
Parallelize transaction validation for transaction sets.
dmkozh Sep 17, 2026
f006455
Disable Soroban diagnostic events on overlay v2 simulation nodes
SirTyson Nov 9, 2026
14de397
Recapture LCM golden data for overlay v2's test PRNG stream
SirTyson Nov 9, 2026
c2acc75
Run make format
SirTyson Nov 10, 2026
fa68014
Remove protocol-version-check from overlay-v2 CI
SirTyson Nov 10, 2026
27713fa
Account for actual elapsed nomination time in the trigger drift allow…
SirTyson Sep 14, 2026
99d3ca7
Record the nomination trigger only when nomination proceeds
SirTyson Nov 9, 2026
9f1802b
Test the trigger anchor with sub-second close times
SirTyson Nov 9, 2026
0e94e51
Add trigger timing metrics
SirTyson Nov 9, 2026
f94e02c
Skip a delayed nomination emit that was already sent
SirTyson Nov 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Describe what this pull request does, which issue it's resolving (usually applic
--->

# Checklist
- [ ] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes) document
- [ ] Reviewed the [contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#opening-a-pull-request) document
- [ ] Rebased on top of master (no merge commits)
- [ ] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio extension)
- [ ] Compiles
Expand Down
92 changes: 92 additions & 0 deletions .github/workflows/overlay-min-version.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
name: Overlay min version

# Once pubnet has upgraded to a new ledger protocol, opens a PR raising
# OVERLAY_PROTOCOL_MIN_VERSION to the lowest overlay version of the releases
# that support that protocol (see scripts/check-overlay-min-version.sh).

on:
schedule:
- cron: '0 15 * * *'
workflow_dispatch:

permissions:
contents: write
pull-requests: write

concurrency:
group: ${{ github.workflow }}
cancel-in-progress: false

jobs:
bump-overlay-min-version:
if: github.repository == 'stellar/stellar-core'
runs-on: ubuntu-24.04
env:
BRANCH: bot/bump-overlay-min-version
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Get pubnet ledger protocol version
id: pubnet
run: |
PROTOCOL=$(curl -sSf --retry 3 https://horizon.stellar.org/ | jq -er '.current_protocol_version | numbers')
echo "Pubnet is on protocol $PROTOCOL"
echo "protocol=$PROTOCOL" >> "$GITHUB_OUTPUT"

- name: Raise OVERLAY_PROTOCOL_MIN_VERSION if possible
env:
PROTOCOL: ${{ steps.pubnet.outputs.protocol }}
run: |
set -o pipefail
./scripts/check-overlay-min-version.sh --apply "$PROTOCOL" | tee "$RUNNER_TEMP/check.txt"

- name: Open or update PR
env:
GH_TOKEN: ${{ github.token }}
PROTOCOL: ${{ steps.pubnet.outputs.protocol }}
BASE: ${{ github.ref_name }}
run: |
if git diff --quiet
then
echo "OVERLAY_PROTOCOL_MIN_VERSION is up to date"
exit 0
fi
MIN=$(sed -n 's/^[[:space:]]*OVERLAY_PROTOCOL_MIN_VERSION[[:space:]]*=[[:space:]]*\([0-9][0-9]*\).*/\1/p' src/main/Config.cpp)

# Leave an open PR alone if it already makes the same change.
OPEN_PR=$(gh pr list --head "$BRANCH" --base "$BASE" --state open --json number --jq '.[].number')
if [ -n "$OPEN_PR" ] &&
git fetch --depth=1 origin "$BRANCH" 2>/dev/null &&
git diff --quiet FETCH_HEAD -- src/main/Config.cpp
then
echo "$BRANCH already raises OVERLAY_PROTOCOL_MIN_VERSION to $MIN"
exit 0
fi

git config user.name 'github-actions[bot]'
git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
git checkout -B "$BRANCH"
git commit -qam "Bump OVERLAY_PROTOCOL_MIN_VERSION to $MIN" \
-m "Pubnet is on protocol $PROTOCOL, and no release supporting it has an overlay version below $MIN."
git push -f origin "$BRANCH"

BODY="$RUNNER_TEMP/body.md"
{
echo "Pubnet is on protocol $PROTOCOL, and no release supporting it has an overlay version below $MIN, so this raises \`OVERLAY_PROTOCOL_MIN_VERSION\` to $MIN. Opened by the \`${{ github.workflow }}\` workflow."
echo
echo "**Reviewer:** before merging, verify that pubnet is on protocol $PROTOCOL and that every release supporting it, including any not tagged in this repo, has \`OVERLAY_PROTOCOL_VERSION\` of at least $MIN. Nodes below $MIN will be disconnected."
echo
echo '```'
cat "$RUNNER_TEMP/check.txt"
echo '```'
} > "$BODY"
if [ -z "$OPEN_PR" ]
then
gh pr create --base "$BASE" --head "$BRANCH" \
--title "Bump OVERLAY_PROTOCOL_MIN_VERSION to $MIN" --body-file "$BODY"
else
gh pr edit "$OPEN_PR" \
--title "Bump OVERLAY_PROTOCOL_MIN_VERSION to $MIN" --body-file "$BODY"
fi
92 changes: 92 additions & 0 deletions .github/workflows/socket-scan.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
# Socket reachability scan for stellar-core.
# For general Socket reachability documentation, see https://docs.socket.dev/docs/full-application-reachability
# Multi-ecosystem: Rust (Cargo) + Python (scripts/pyproject.toml).
#
# --reach-ecosystems=cargo,pypi explicitly lists the ecosystems that get full Tier 1 reachability analysis. This repo's Coana-supported ecosystems are cargo (Cargo.toml) and pypi (scripts/pyproject.toml). The explicit list also excludes Coana's phantom NUGET detection: the repo has Builds/VisualStudio/stellar-core.sln (no actual C# code), which Coana otherwise mis-detects as a .NET project and aborts the scan demanding `dotnet`. Listing only cargo,pypi sidesteps that.
#
# >>> DEVELOPERS: if this repo adds a NEW Coana-supported ecosystem (e.g. an >>> npm package.json, a go.mod, a Gemfile), you MUST add that ecosystem to >>> this --reach-ecosystems list to get full Tier 1 reachability for it. >>> Supported ecosystem names: npm, pypi, cargo, golang, maven, gem, nuget. >>> Ecosystems NOT listed here still receive Tier 2 (precomputed) >>> reachability from Socket's backend automatically — but Tier 1 (the more >>> precise, your-code-aware analysis) only runs for the ecosystems listed.
#
# Schedule: Sun 12:24 UTC weekly. Use workflow_dispatch to run on demand.
#
# ============================================================================
# Socket scan — reading the job status. (The scan step below produces this: an
# exit code + an optional ::warning:: annotation, which GitHub Actions renders
# as the job's state.)
# ============================================================================
# GREEN (exit 0, no warning): scan completed and every analyzed vulnerability
# got full Tier 1 reachability (precise, your-code-aware). Nothing to do.
# YELLOW (exit 0 + "::warning:: Socket scan completed with Tier 2 fallbacks"):
# scan completed, but Tier 1 could NOT be computed for some/all
# vulnerabilities, which fell back to Tier 2 (precomputed) reachability.
# You still get CVE detection + Tier 2 results, just reduced precision
# for the affected CVEs. The job is NOT failing.
# RED (non-zero exit): scan did not complete. Do not assume any part
# succeeded — could be reachability hard-failing, a missing language
# toolchain, the runner out of memory, a network/API error, or even the
# underlying CVE/SBOM detection failing. Check the logs and fix before
# relying on results.
# ----------------------------------------------------------------------------
# THIS REPO STARTS YELLOW — a KNOWN upstream Coana bug, NOT your code or this
# scan setup:
# Coana's Rust analyzer hits "Maximum call stack size exceeded" on the cargo
# root + src/rust (4 CVEs) -> Tier 2 fallback.
# Reported to Socket; may be fixed upstream over time. Do NOT let this baseline
# yellow train the team to ignore yellow — a *new* yellow (a different Tier 2
# fallback that appears later) is a real signal worth investigating. After the
# initial rollout, the team may resolve the baseline yellow at its discretion
# (once Coana ships a fix, or by adjusting the scan) so GREEN becomes the
# normal state and any future yellow stands out.
# ============================================================================

name: Socket reachability scan

on:
schedule:
- cron: '24 12 * * 0'
workflow_dispatch:

permissions:
contents: read

jobs:
socket-scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- run: rustup update
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: "3.14.6"
- uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "24.18.0"

- name: Install Socket CLI
run: npm install -g socket

- name: Run Socket reachability scan
env:
SOCKET_SECURITY_API_TOKEN: ${{ secrets.SOCKET_SECURITY_API_TOKEN }}
run: |
# Stream the scan output through tee so the run log captures it AND
# we can grep it for Tier-2-fallback markers; capture the scan's
# exit code via ${PIPESTATUS[0]} (tee always exits 0). If the scan
# succeeded but logged a Tier 2 fallback, emit a ::warning::
# annotation that GitHub Actions renders as a yellow run-level
# warning without failing the job.
set +e
socket scan create --reach \
--org=stellar \
--no-interactive \
--reach-continue-on-no-source-files \
--reach-continue-on-analysis-errors \
--reach-continue-on-install-errors \
--reach-continue-on-missing-lock-files \
--reach-ecosystems=cargo,pypi \
. 2>&1 | tee /tmp/scan.log
rc=${PIPESTATUS[0]}
if [ $rc -eq 0 ] && grep -qE "Reachability falls back to Tier 2|fallback to the results from the pre-computed|Reachability falls back to precomputed" /tmp/scan.log; then
echo "::warning::Socket scan completed with Tier 2 fallbacks - some vulnerabilities used precomputed reachability instead of full Tier 1"
fi
exit $rc
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ compile_commands.json
# tracy binaries
/tracy-capture
/tracy-gui
/tracy-import-chrome

# test output
stellar-core-test-*
Expand Down
7 changes: 7 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@
[submodule "src/rust/soroban/p28"]
path = src/rust/soroban/p28
url = https://github.com/stellar/rs-soroban-env.git
[submodule "src/rust/soroban/p29"]
path = src/rust/soroban/p29
url = https://github.com/stellar/rs-soroban-env.git
branch = release/v29.0.0-internal
[submodule "src/rust/soroban/p30"]
path = src/rust/soroban/p30
url = https://github.com/stellar/rs-soroban-env.git
[submodule "lib/gperftools"]
path = lib/gperftools
url = https://github.com/gperftools/gperftools.git
2 changes: 2 additions & 0 deletions Builds/VisualStudio/stellar-core.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,7 @@ exit /b 0
<ClCompile Include="..\..\src\util\test\Uint128Tests.cpp" />
<ClCompile Include="..\..\src\util\test\XDRStreamTests.cpp" />
<ClCompile Include="..\..\src\util\TarjanSCCCalculator.cpp" />
<ClCompile Include="..\..\src\util\TcmallocConfig.cpp" />
<ClCompile Include="..\..\src\util\Thread.cpp" />
<ClCompile Include="..\..\src\util\TmpDir.cpp" />
<ClCompile Include="..\..\src\util\Timer.cpp" />
Expand Down Expand Up @@ -1280,6 +1281,7 @@ exit /b 0
<ClInclude Include="..\..\src\util\SociNoWarnings.h" />
<ClInclude Include="..\..\src\util\StatusManager.h" />
<ClInclude Include="..\..\src\util\TarjanSCCCalculator.h" />
<ClInclude Include="..\..\src\util\TcmallocConfig.h" />
<ClInclude Include="..\..\src\util\Thread.h" />
<ClInclude Include="..\..\src\util\TmpDir.h" />
<ClInclude Include="..\..\src\util\Timer.h" />
Expand Down
6 changes: 6 additions & 0 deletions Builds/VisualStudio/stellar-core.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,9 @@
<ClCompile Include="..\..\src\util\TarjanSCCCalculator.cpp">
<Filter>util</Filter>
</ClCompile>
<ClCompile Include="..\..\src\util\TcmallocConfig.cpp">
<Filter>util</Filter>
</ClCompile>
<ClCompile Include="..\..\src\util\Thread.cpp">
<Filter>util</Filter>
</ClCompile>
Expand Down Expand Up @@ -1737,6 +1740,9 @@
<ClInclude Include="..\..\src\util\TarjanSCCCalculator.h">
<Filter>util</Filter>
</ClInclude>
<ClInclude Include="..\..\src\util\TcmallocConfig.h">
<Filter>util</Filter>
</ClInclude>
<ClInclude Include="..\..\src\util\Thread.h">
<Filter>util</Filter>
</ClInclude>
Expand Down
101 changes: 95 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,53 @@ Guide](https://github.com/stellar/.github/blob/master/CONTRIBUTING.md) for detai
to stellar-core and Stellar's other repositories, especially with regard to our code of conduct and
contributor license agreement.

## Submitting Changes
The repository-specific requirements below take precedence where they are more restrictive than the
general Stellar Contribution Guide.

Fork the `stellar/stellar-core` repo on github and submit a pull request from a branch in your fork.
Key things to keep in mind:
* Keep your branch up-to-date by rebasing on `stellar/stellar-core` `master`
* Ensure your branch focuses on a single issue at a time
* Before merging, squash your commits and ensure you have a descriptive commit message
## Before Contributing

Stellar Core processes live financial transactions. Correctness is critical, and maintainer and
reviewer time is limited. We welcome contributions that address a demonstrated, material problem or
advance work that maintainers have agreed is a priority.

### Start With an Issue

Before creating an issue, search the existing issues and join a relevant discussion if an existing issue is present.
When creating a new issue, you should establish:

* The concrete problem that needs solving.
* For a bug, include a minimal reproducer with the expected and actual behavior whenever possible.
* Relevant alternatives, if any, and their tradeoffs.
* For a performance change, measurements that show the current problem and provide a baseline for evaluating a solution.

Personally verify findings before reporting them. Do not submit speculative findings or generated lists of possible issues.

Opening an issue does not reserve the work or mean that a code change is wanted.
An issue with the `help wanted` label is available for implementation, but contributors should
still discuss their proposed approach on the issue before starting substantial work.

### Participation and Review

Keep your participation to issues and do not post comments on pull requests. Issue comments should be specific and evidence-based.
Comments must not be about implementation strategies unless explicitly invited to do so.
Maintainers will delete issue comments that are irrelevant to the issue.
Proceed with a pull request only when invited by the maintainers, including for issues with the `help wanted` label.

## Opening a Pull Request

We are currently only accepting pull requests for issues with the `help wanted` label.
Unsolicited pull requests will be closed without an explanation and reported as spam.
Making changes to stellar-core requires deep architectural knowledge, a good understanding of system constraints, and
an idea about the project roadmap. External contributors often do not have this context, and their pull requests
typically focus on lower-priority issues. Reviewing those changes takes the maintainers' focus away from higher-priority work.

Key things to keep in mind when creating a pull request:

* Fork the `stellar/stellar-core` repository and submit the pull request from a branch in your fork.
* Link the approved issue and keep the pull request within the agreed scope.
* Keep your branch up-to-date by rebasing on `stellar/stellar-core` `master`.
* Ensure your branch focuses on a single issue at a time.
* Before merging, squash your commits and ensure you have a descriptive commit message.

## Stellar Core Contribution Specifics

Expand Down Expand Up @@ -294,6 +334,55 @@ files. You should then inspect to see that only the transactions you expected to
see change did so. If so, commit the changes as a new set of baselines for
future tests.

## Running and updating LedgerCloseMeta checks

Alongside the TxMeta hashes above, the unit tests can capture the full
`LedgerCloseMeta` XDR of every ledger they close, and check it against golden
data stored in the repository. Where the TxMeta baselines record a hash per
transaction, this records the complete binary meta, so the files also serve as
test data for downstream consumers such as Horizon and RPC. The two modes are:

* `--capture-lcm` which writes golden files, and
* `--check-lcm <dirname>` which checks against them, where `<dirname>` is the
directory holding the golden trees (the source tree root).

The golden data lives in `test-lcm-current` (for the current protocol) and
`test-lcm-next` (for the next protocol), one subdirectory per test file, one
file per leaf section, named by a truncated hash of the test and section names.
Each subdirectory's `index.json` maps those hashes back to the names (test case
and sections joined with `|`, as in the TxMeta baselines) and
records the protocol version and rng seed that produced the data. Continuous
integration runs `--check-lcm`, which fails fast if those headers do not match
the running binary — so a protocol version bump requires re-capturing the
data, even when no transaction semantics changed.

To re-capture after an intentional change, after a protocol bump, or after
merging in a `master` that changed the golden data, run from the source tree
root:

stellar-core test [tx] --rng-seed 12345 --capture-lcm

for a build with only the current protocol enabled, and the same command for a
build configured with `--enable-next-protocol-version-unsafe-for-production`,
which writes the `next` tier instead. Note there is no `--all-versions` here:
the golden data is captured at the default (latest) protocol version only.

Capture is a full-corpus operation: after a clean run it rebuilds each visited
test file's `index.json` from what it captured and deletes golden files the run
did not write, so leaves that are no longer produced do not accumulate. This is
the same behaviour as `--record-test-tx-meta`. A run filtered to a subset of
tests therefore deletes the goldens of sibling tests in the same file; that is
fine while iterating locally, but always finish with the full `[tx]` run above
before committing.

Some tests are automatically skipped because their meta cannot serve as
golden data: those that inject ledger entries straight
into the bucket list (the meta never shows the entries being created), those
that run a multi-node `Simulation`, and those using a config whose ledger
content depends on thread scheduling or randomized nomination. If you add a
test that needs a golden vector, close its ledgers through the ordinary
single-node path.

## Fastdev and non-unified Rust builds

As of protocol 20, some components of stellar-core are written in Rust (notably
Expand Down
Loading
Loading