Repository navigation
Conversation
… Credible Set layout
…stall integraty check error
| scale_function: 'if', | ||
| parameters: { | ||
| field_value: true, | ||
| then: '#FFf000', |
There was a problem hiding this comment.
This was setting the selected marker fill to yellow, which was inconsistent with other layouts/plots.
| _getCacheKey (state) { | ||
| const threshold = state.credible_set_threshold || this._config.threshold; | ||
| return [threshold, state.chr, state.start, state.end].join('_'); | ||
| return [state.ldrefvar, threshold, state.chr, state.start, state.end].join('_'); |
There was a problem hiding this comment.
When the ldrefvar was updated, we'd receive a cache hit on the credible set data, which would return the set of data with the stale lz_is_ld_ref value. Including state.ldrefvar in the cache key ensures that the credible set data is "re-joined" with the new ldrefvar, instead of just retrieving the cached data.
| }, | ||
| "jszlib": { | ||
| "version": "git+ssh://git@github.com/dasmoth/jszlib.git#4e562c7b88749f3e1e402737ddef5f96bf0906c6", | ||
| "integrity": "sha512-L+slw277qqgqWvyz6srOUOqHnbuyLBGPkgzM7IgxCTb/MVTNiy11iQ15mS+dO2f8UIjKBb4z8AgO3vshLrjXVg==", |
There was a problem hiding this comment.
The github action was throwing an integrity check error. An npm install updated the problematic integrity checksum value (fortunately).
|
Note: it's been a very long time, but the yellow-on-click behavior was (probably) a holdover from an earlier design where the credible set was a separate panel, and clicking any point would cause matching points to be highlighted in any other panel. It's up to the current repo owners to review things, but hopefully this helps with the design / intent part of review. :) |
This PR fixes an issue where the LD Ref diamond marker was not updated after the LD Ref was changed in a credible set layout. Additionally, the selected variant was being filled "yellow" in a credible set layout, which is inconsistent with other layout types. Here is a screen recording that demonstrates the LD Ref bug:
Screen.Recording.2026-10-28.at.1.21.39.PM.mov
Screen capture of the undesireable yellow selection:

Screen recording after the fix (in pheweb-trans-omic):
Screen.Recording.2026-10-28.at.1.44.48.PM.mov