Conversation
…ort additional fields
Added configuration for Istio VirtualService.
Added tests for Istio VirtualService configuration including rendering conditions, API version handling, and route specifications.
- Introduced a comprehensive schema for the VirtualService configuration, including properties such as enabled, exportTo, gateways, hosts, http, routes, tcp, and tls. - Enhanced descriptions for each property to clarify usage and requirements. - Removed the previous, less detailed VirtualService schema to streamline the configuration process.
a82198c to
2e1ef21
Compare
|
Thanks for the PR, the template and tests are in good shape. Three things block merge, the rest are suggestions. Blocking1. Wildcard hosts render invalid YAML. 2. Feature is not enabled in CI values. Per CONTRIBUTING, new features must be enabled in 3. Labels and annotations. Every other networking template ( Suggestions
Happy to re-review once the two blocking items are in. |
…st for wildcard hosts
|
I appreciate the feedback! |
Changes
virtualServicesection tovalues.yamlwith full documentation (hosts,gateways,exportTo,http,tls,tcp,routes)virtualServiceschema block tovalues.schema.jsontemplates/virtualservice.yaml: supports single-VS and multi-VS (routesmap) modes;http/tls/tcparetoYamlpass-through.networking.istio.io/v1vsv1beta1Remarks
virtualService.enableddefaults tofalseto be fully backwards compatibleroutesis omitted, a single VirtualService is rendered using the top-levelvirtualServicefields; whenroutesis a map, one VirtualService is rendered per entry (name suffix skipped when key is"default")