Repository navigation
Reads gate: type thin-evidence species (one strain or 1-3 runs) as UNVALIDATED instead of holding them - #327
Merged
Merged
Conversation
… and capped at UNVALIDATED instead of held Curator 2026-11-09: species with a single strain in the assembly DB (single_locus) or fewer than 4 runs (few_runs_<n>) go on to typing; the decision is capped at UNVALIDATED with those reasons first. Hard floors: an idiomorph with no locus, or no runs at all, still hold the species. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… UNVALIDATED (thin), 4 HOLD on their numbers Re-plan of the species held for too_few_loci / too_few_runs_1-3 with the thin-evidence gate (run-37856af, v0.8.1 inputs), stage thin per wave (results/2026-11-09_thin_evidence_replan on the HPCC), merged append-only by orchestration/merge_thin_2026-11-09.py; changed rows in wave*/thin_changes.tsv. New committed folder wave5_basidio (C. amylolentus; the two Malassezia stay panel_build_failed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eld for too_few_runs_0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curator request (2026-11-09): Pneumocystis and other species with only one strain in the assembly DB, or only a few runs, should still be typed from reads instead of being held. Curator ruling: type them, cap the decision at UNVALIDATED and show the reason.
Why the old floors existed
min_runs=4andmin_loci=2date from the first wave driver (c97fe2c), and nothing records a rationale. The 4 works as a sample-size floor for the test fractions: with 1 run, "typed ≥ 75%" can only be 0 or 1.min_loci=2guards against a panel cut from one strain's locus, which can miss divergent strains. Both risks remain, so these species are now labelled rather than hidden.What
wave_driver.pyplan-one: a species now holds only when an idiomorph has no locus (too_few_loci) or no run (too_few_runs_0). Below the old floors it writesplan/<slug>/thinwith:single_locus: an idiomorph's panel comes from one assembled locus;few_runs_<n>: 1 to 3 runs.decide_species(..., thin)caps the decision atUNVALIDATED, with the thin tokens first. A HOLD stays a HOLD (the tokens are added) and a NOT_TYPABLE cause is unchanged.gaterecords them asthin=a+bin the reasons.regate,curateandapply-causeskeep them.merge_screen.py: the re-gating of species that gained runs keeps the cap. Before this fix, a later screen merge would have lifted a thin species back up.build_reads_site.py: wording for the two reasons ("thin evidence: only 2 runs available to type"; "…the panel of an idiomorph comes from a single assembled locus (one strain)…").CONTRACT.md(Waves) and the module docstring.Data: the held species, re-planned and typed
Re-plan of the 22 species held for
too_few_lociortoo_few_runs_1-3. Left out: the members of the complexes already typed as groups (C. gattii, Blumeria, Sporothrix) and the two species with 0 runs.run-37856af, v0.8.1 inputs (waves 1 and 2 had been planned on the v0.7.0 tables).thinper wave, 204 runs, all done, none to rerun (HPCCresults/2026-11-09_thin_evidence_replan/).orchestration/merge_thin_2026-11-09.py. Existing rows are untouched (git diff --numstatshows only added rows). Every changed gate row is inwave*/thin_changes.tsv. The new folderwave5_basidioholds C. amylolentus, and its two Malassezia staypanel_build_failed.few_runs_<n>both, so alsocause_unchecked)single_locusboth)A. quadrilineatus (2 of 2
both) is likely homothallic like A. nidulans. It could get acauses.tsvrow after a look at its assemblies. That is not done here.Checks
runs_fullgives at most 50; only Hymenoscyphus reaches 41).🤖 Generated with Claude Code