Repository navigation
Reads gate causes for v0.9.0 (#195, #196): not typable, zygosity, unchecked; cause table; site wording - #325
Merged
Merged
Conversation
…lent_cassettes, zygosity additions, HOLD:cause_unchecked; apply-causes; site wording; availability action Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nges.tsv per wave); cause_evidence.tsv (42 species); CONTRACT section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llic; cause_unchecked visible as UNVALIDATED; the 50%-both shortcut no longer claims homothallism Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es.tsv relative to main); evidence table regenerated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the v0.9.0 checklist on #195 and #196, following the curator ruling on the design note (#321) and the grilling of 2026-11-09 (decisions Q1–Q9 below).
What
datasets/reads/sra_survey/pilot/causes.tsv(curated). One row per species: species, cause, build_cause, basis, with the evidence for each.homothallic: both MAT genes in every genome, at one locus or unlinked loci →NOT_TYPABLE:homothallic.silent_cassettes→NOT_TYPABLE:silent_cassettes.zygosity: joinsZYGOSITY, sobothis MTL a/alpha.cause_unchecked→UNVALIDATED:cause_uncheckedplus the usual soft reasons.wave_driver.py:gate,regateandcurate, and also for species held at the panel stage;apply-causes;bothshortcut no longer gives PROVISIONAL_HOMOTHALLIC: a species with no cause getsUNVALIDATED:cause_unchecked(Q3);submit-fulldoes not queue NOT_TYPABLE species.cause_evidence.py(new) →cause_evidence.tsv(42 species). For each species it gives:loci.tsv);wave*/cause_changes.tsv. 18 were a HOLD, 12 PROVISIONAL_HOMOTHALLIC and 6 UNVALIDATED.reads_availability.py: new actionnot_typable.CONTRACT.mdhas a new causes section.Decisions that change (all listed in
cause_changes.tsv)NOT_TYPABLE:homothallicNOT_TYPABLE:silent_cassettesUNVALIDATED:cause_uncheckedC. dubliniensis and C. viswanathii get the cause
zygosity, but stayHOLD:panel_build_failed, a technical reason: their panel loci are all a. L. orthopsilosis and Mucor hiemalis have a build cause only.Why the yeast panels failed (#196). In every failed build, the panel's assembly loci cover one idiomorph only, so there is nothing to build from:
Curator decisions (grilling, 2026-11-09)
homothallic; the locus layout goes inbasis.bothrule no longer claims homothallism.silent_cassettes; its 263 single calls are noted on Reads: copy-number ratio test for active MAT in cassette yeasts and MTL zygosity #322.homothallic.C. fimbriata. The 7 assemblies v0.8.1 skipped (taxid 5158 has no NCBI lineage) were searched on the taxid route (1035309). Each carries unmodelled hits of both MAT1-1-1 and MAT1-2-1, and none carries one idiomorph only. A
--phylumattempt and a control on the called assembly showed that--phylumleaves every gene unmodelled. Both detector problems are filed as #324.Checks
tests/test_wave_driver_gate.py(cause overrides, apply-causes, the causes file uses only ruled causes),tests/test_cause_evidence.py, and a not-typable test intests/test_build_reads_site_script.py.Closes the v0.9.0 checklists of #195 and #196. The issues stay open for v0.10.0 (#322, #323).
🤖 Generated with Claude Code