chore: move dependencies used by a single crate to said crate (#1729) - #1732
chore: move dependencies used by a single crate to said crate (#1729)#1732Molter73 wants to merge 1 commit into
Conversation
After an automated update of bindgen broke our build due to a dependency conflict, I did some digging and turns out that was solved by simply moving the bindgen dependency to fact-ebpf which is the only crate that needs it. In order to reduce the chances of this kind of breakage from happening, we are moving all dependencies that are needed by a single crate to said crate.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.4 #1732 +/- ##
============================================
Coverage 33.40% 33.40%
============================================
Files 22 22
Lines 3628 3628
Branches 3628 3628
============================================
Hits 1212 1212
Misses 2407 2407
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
After an automated update of bindgen broke our build due to a dependency conflict, I did some digging and turns out that was solved by simply moving the bindgen dependency to fact-ebpf which is the only crate that needs it. In order to reduce the chances of this kind of breakage from happening, we are moving all dependencies that are needed by a single crate to said crate.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough.