chore: move dependencies used by a single crate to said crate (#1729) - #1731
Open
Molter73 wants to merge 1 commit into
Open
chore: move dependencies used by a single crate to said crate (#1729)#1731Molter73 wants to merge 1 commit into
Molter73 wants to merge 1 commit into
Conversation
After an automated update of bindgen broke our build due to a dependency conflict, I did some digging and turns out that was solved by simply moving the bindgen dependency to fact-ebpf which is the only crate that needs it. In order to reduce the chances of this kind of breakage from happening, we are moving all dependencies that are needed by a single crate to said crate.
ovalenti
approved these changes
Sep 10, 2026
ovalenti
left a comment
ovalenti
left a comment
Contributor
There was a problem hiding this comment.
The backport differences look correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After an automated update of bindgen broke our build due to a dependency conflict, I did some digging and turns out that was solved by simply moving the bindgen dependency to fact-ebpf which is the only crate that needs it. In order to reduce the chances of this kind of breakage from happening, we are moving all dependencies that are needed by a single crate to said crate.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough