Repository navigation
docs(plan): laddercodec folds a rung comment to ASCII, and Sam has not ruled on the fix - #94
Merged
Merged
Conversation
…t ruled on the fix The laddercodec session found the fault. The fix waits on a runner case and on Sam's choice for a character that cp1252 lacks. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
laddercodec's encode folds a rung comment to ASCII with no message, so an accent or a degree sign is lost on the way into CLICK. ClickNick's paste encodes the whole file, so the loss reaches comments that the user did not edit. The laddercodec row records the fault and what the fix waits on. The five bytes that Python's cp1252 lacks are not a fault in laddercodec, and they get a line with the same round.