Repository navigation
fix(codes): split same-address ranges and refuse even TXT sends - #166
Merged
Merged
Conversation
A range with the same address at both ends, such as C1..C1, is now duplicate-address in every field: Coil, Block Copy, Pack, Unpack, Fill and Search. range-not-ascending now means only an end below the start. The ids stay where they were: OBJ-012 for the same address and OBJ-009 for an end below. CLICK_IDS lists OBJ-012 under duplicate-address only. A Fill range outside SD now has these ids too. A Fill into SD from a read-only start SD is refused as not-writable with OBJ-004 after the pairing, whatever the order of its ends, so SD1..SD1 and SD2..SD1 are not-writable. A Fill into SD from a writable start checks the order of its ends first, as the other banks do, and that refusal has no id. A Fill range in two banks has no id either. Each of these refusals now ends with what to write, such as "Write an end above C1, such as C2." The example skips X and Y numbers outside a slot and keeps to writable SC bits for a Coil. A refusal of a Fill into SD names a range of writable SD registers, such as SD31..SD32. address_above and range_then build the sentence, in operands/address.py. A Send from an even TXT address, such as TXT1000, is refused with the new code txt-start-not-odd and OBJ-028, and its count is not checked. The message names an odd start from which the count ends by TXT1000. A Receive into TXT is unchanged. A Fill into TXT of a negative integer, or of an integer or hex constant of several digits, keeps constant-out-of-range and now has OBJ-023. CODES_COMPARED goes from 4925 to 4959. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the 2026-11-19 rulings on same-address ranges, OBJ-028 and OBJ-023.
What changes
Same address at both ends
A range such as
C1..C1is nowduplicate-addressin Coil, Block Copy, Pack, Unpack, Fill and Search.range-not-ascendingnow means only an end below the start. The exception classes are unchanged.Fill range ids
Fill ranges now get the ids CLICK answers:
SD1..SD1,SD2..SD1).A writable start SD checks the order of its ends first, as the other banks do.
txt-start-not-oddNew code. A Send from an even TXT address, such as
TXT1000, is refused with OBJ-028. v0.4.0 accepted it. A Receive into TXT is unchanged.Fill OBJ-023
A Fill into TXT of a negative integer, or of an integer or hex constant of several digits, keeps
constant-out-of-rangeand now has OBJ-023.Messages
Each of these refusals now ends with what to write, and the example is one the field accepts.
.codechanges for pyrungrange-not-ascendingduplicate-addressrange-not-ascending/duplicate-addresson dest_endnot-writableon dest_start, OBJ-004count-out-of-rangeonSend.quantitytxt-start-not-oddonSend.sourceChecks
make lint,make docs-buildanddevtools/editor_grids.py --checkpass.make test: 19144 passed, 139 skipped.Open, on the roadmap