Skip to content

fix(drum): give drum events and a For count their answered CLICK ids - #162

Merged
ssweber merged 1 commit into
mainfrom
fix/drum-ids
Nov 20, 2026
Merged

ssweber merged 1 commit into
mainfrom
fix/drum-ids

Conversation

@ssweber

@ssweber ssweber commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Adds CLICK ids to drum event and For count refusals where CLICK v4.00's dialog answers record them. Only click_id changes: every input refused or accepted before is refused or accepted the same way now.

Drum events

Id Shapes Examples
OBJ-005 a comparison, a list in brackets, an address in parentheses, two addresses separated by a space DS5>3, X1==1, C1<>C2, [C1,C2], (C1), C1 C2
OBJ-002 an X or Y number that no point has X017, X020, X100, Y117
OBJ-003 a number above the bank's highest address C2001, T501, X817
OBJ-003 the display form of 0 X000, C0, SC0
  • The id is read from the event as typed, so X0, X00 and x017 get none.
  • Lowercase pointers such as x[DS1] keep their OBJ-005.
  • The event drum and the time-and-event drum share the check. drum_events_shapes answers both kinds alike.

For count

A count of 16 characters or fewer that is a number with a point carries OBJ-005, such as 1.5, -.5, 1. or 1.5E3. The number may have a sign and an exponent. CLICK refuses a point whatever the value, as 1. and 1.5E3 show.

Answers

  • drum_events_exprs.json and its answers file are imported from CLICK v4.00's dialog: 7 cases.
  • CODES_COMPARED goes from 4880 to 4925.
  • CLICK_IDS[address-out-of-range] is now OBJ-002 and OBJ-003, and codes.md is regenerated.

Left without an id (no answer)

  • X0000000, C00 and lowercase events.
  • The operators <, >=, <=, = and !=.
  • For counts with an exponent and no point, such as 1E5.
  • Signed integers such as -5.

Gate

  • make lint: passed.
  • editor_grids.py --check: passed.
  • make docs-build: passed.
  • make test on the rebased branch: 18920 passed, 139 skipped.

A drum event refused as not an address now carries OBJ-005 when it is
a comparison such as DS5>3 or X1==1, a list in brackets, an address in
parentheses, or two addresses with a space between them. An event out
of range carries OBJ-002 for an X or Y number that no point has, such
as X017, and OBJ-003 above the bank's highest address or at the
display form of 0, such as C2001 or X000. An event's id is read from
the text as typed. X0, X00 and x017 get no id.

A For count of 16 characters or fewer that is a number with a point,
with an optional sign and exponent, such as 1.5, -.5, 1. or 1.5E3,
carries OBJ-005.

Imports drum_events_exprs from CLICK v4.00's dialog answers. The tests
compare each id with its answer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ssweber
ssweber merged commit 7063264 into main Nov 20, 2026
7 checks passed
@ssweber
ssweber deleted the fix/drum-ids branch November 20, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant