Repository navigation
fix(drum): give drum events and a For count their answered CLICK ids - #162
Merged
Merged
Conversation
A drum event refused as not an address now carries OBJ-005 when it is a comparison such as DS5>3 or X1==1, a list in brackets, an address in parentheses, or two addresses with a space between them. An event out of range carries OBJ-002 for an X or Y number that no point has, such as X017, and OBJ-003 above the bank's highest address or at the display form of 0, such as C2001 or X000. An event's id is read from the text as typed. X0, X00 and x017 get no id. A For count of 16 characters or fewer that is a number with a point, with an optional sign and exponent, such as 1.5, -.5, 1. or 1.5E3, carries OBJ-005. Imports drum_events_exprs from CLICK v4.00's dialog answers. The tests compare each id with its answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CLICK ids to drum event and For count refusals where CLICK v4.00's dialog answers record them. Only
click_idchanges: every input refused or accepted before is refused or accepted the same way now.Drum events
DS5>3,X1==1,C1<>C2,[C1,C2],(C1),C1 C2X017,X020,X100,Y117C2001,T501,X817X000,C0,SC0X0,X00andx017get none.x[DS1]keep their OBJ-005.For count
A count of 16 characters or fewer that is a number with a point carries OBJ-005, such as
1.5,-.5,1.or1.5E3. The number may have a sign and an exponent. CLICK refuses a point whatever the value, as1.and1.5E3show.Answers
drum_events_exprs.jsonand its answers file are imported from CLICK v4.00's dialog: 7 cases.CODES_COMPAREDgoes from 4880 to 4925.CLICK_IDS[address-out-of-range]is now OBJ-002 and OBJ-003, andcodes.mdis regenerated.Left without an id (no answer)
X0000000,C00and lowercase events.<,>=,<=,=and!=.1E5.-5.Gate
make lint: passed.editor_grids.py --check: passed.make docs-build: passed.make teston the rebased branch: 18920 passed, 139 skipped.