fix(http_client) :: test which variables select the system trust store - #1435
Open
81reap wants to merge 1 commit into
Open
fix(http_client) :: test which variables select the system trust store#143581reap wants to merge 1 commit into
81reap wants to merge 1 commit into
Conversation
`SSL_CERT_FILE` and `SSL_CERT_DIR` decide whether `sqlpage.fetch` and `send_mail` trust the system root certificates or the bundled ones. This addes tests for these cases.
81reap
marked this pull request as ready for review
September 7, 2026 03:47
lovasoa
requested changes
Sep 10, 2026
lovasoa
left a comment
lovasoa
left a comment
Collaborator
There was a problem hiding this comment.
I don't think this is the right level to test this. This is verbose and does not actually test the feature. Certificate selection could be broken and this would pass
If you think this part of the code is brittle, I think a higher level test is more appropriate. One that tests end 2 end which certificates are selected when using fetch or send mail. This is the kind of integration tests we run inside ./examples. You could add an example about ssl certificates and a hurl test for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL_CERT_FILEandSSL_CERT_DIRdecide whethersqlpage.fetchandsend_mailtrust the system root certificates or the bundled ones. This addes tests for these cases.discovered buy #1396