test(log) :: test the log component in both render phases - #1433
Merged
Conversation
SQLPage handles a log row two ways :: (1) before the body opens, the header phase stays open, so a cookie can still follow a log, and (2) after the body opens, the row goes to the server log instead of onto the page. Adds tests for these cases.
81reap
marked this pull request as ready for review
September 7, 2026 02:45
lovasoa
changed the title
lovasoa
approved these changes
Sep 10, 2026
lovasoa
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLPage handles a log row two ways ::
(1) before the body opens, the header phase stays open, so a cookie can still follow a log, and
(2) after the body opens, the row goes to the server log instead of onto the page. Adds tests for these cases.
discovered by #1396