Skip to content

[test]:Added that deletes a newly created record set - #8553

Open
gabek96 wants to merge 1 commit into
mainfrom
issue-8550
Open

gabek96 wants to merge 1 commit into
mainfrom
issue-8550

Conversation

@gabek96

@gabek96 gabek96 commented Sep 17, 2026

Copy link
Copy Markdown

Fixes # 8550

Created a test that deletes a newly created record set

Summary by CodeRabbit

  • Tests
    • Added coverage verifying that recordsets can be deleted successfully and are removed from the database.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 88aee820-8d32-4f10-9ea1-c9aaede27826

📥 Commits

Reviewing files that changed from the base of the PR and between df8e900 and 0e788cf.

📒 Files selected for processing (1)
  • specifyweb/backend/businessrules/tests/test_delete_new_resource.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change adds a test that creates a Recordset, deletes it, and verifies that the record no longer exists in the database.

Changes

Recordset deletion coverage

Layer / File(s) Summary
Recordset deletion assertion
specifyweb/backend/businessrules/tests/test_delete_new_resource.py
Adds test_delete_recordset, which creates a Recordset with required fields, deletes it, and asserts that the record is absent.

Suggested reviewers: carolinedenis

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to 0e788

This test-only change adds valid Recordset deletion coverage and presents no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Testing Instructions ⚠️ Warning The PR description does not provide testing instructions. It only states that a test was created. The repository template requires a Testing instructions section, and the changed component is `specify… Add a Testing instructions section to the PR description. State the backend test environment prerequisites and provide a command such as `./ve/bin/python manage.py test specifyweb.backend.businessrules.tests.test_delete_new_resource.TestDel…
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies a test for deleting a newly created record set. It matches the main change in the pull request, although the wording could be slightly more concise.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Automatic Tests ✅ Passed The PR adds an automatic test in specifyweb/backend/businessrules/tests/test_delete_new_resource.py. test_delete_recordset creates a Recordset, deletes it, and asserts that the record no longer …
Full details: Testing Instructions

Explanation

The PR description does not provide testing instructions. It only states that a test was created. The repository template requires a Testing instructions section, and the changed component is specifyweb/backend/businessrules/tests/test_delete_new_resource.py, which is not identified with a runnable test command or verification steps.

Resolution

Add a Testing instructions section to the PR description. State the backend test environment prerequisites and provide a command such as ./ve/bin/python manage.py test specifyweb.backend.businessrules.tests.test_delete_new_resource.TestDeleteObjects.test_delete_recordset. State that the test must confirm that the newly created Recordset is absent after deletion. Optionally include the repository backend suite command, ./ve/bin/python manage.py test --verbosity=3 --keepdb, for broader coverage.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gabek96 gabek96 linked an issue Sep 18, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

[Test]:Delete a newly created record set

1 participant