Repository navigation
Add support for Guzzle 8 - #509
Merged
Merged
Conversation
Widen the guzzle and psr7 constraints to allow Guzzle 8 alongside 7. Guzzle 8 removed getResponse() from RequestException (it now lives on response-carrying subclasses only), so CollectUrlsObserver reads the response via BadResponseException / TooManyRedirectsException, which expose it identically in both Guzzle 7 and 8. CI runs the test suite and PHPStan against both Guzzle 7 and 8. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the
guzzlehttp/guzzleandguzzlehttp/psr7constraints to allow Guzzle 8 alongside 7. No breaking changes for Guzzle 7 users.Guzzle 8 removed
getResponse()fromRequestException, soCollectUrlsObservernow reads the response viaBadResponseException/TooManyRedirectsException, which expose it identically in both Guzzle 7 and 8.The test suite and PHPStan now run against both Guzzle 7 and 8 in CI.