Clean up the BMC Kconfig - #620
Open
DannyIsa wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
DannyIsa
force-pushed
the
master_sonic_aspeed_bmc_kconfig_cleanup
branch
from
September 3, 2026 07:30
6cadf5b to
1fb9d88
Compare
DannyIsa
changed the title
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Signed-off-by: Daniel Isakov <disakov@nvidia.com>
DannyIsa
force-pushed
the
master_sonic_aspeed_bmc_kconfig_cleanup
branch
from
September 3, 2026 07:33
1fb9d88 to
4a94a67
Compare
DannyIsa
changed the title
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
@saiarcot895 could you please help review? |
saiarcot895
reviewed
Sep 3, 2026
| # CONFIG_CRYPTO_DEV_ASPEED_HACE is not set | ||
| # CONFIG_CRYPTO_DEV_ASPEED_RSSS is not set | ||
| # CONFIG_CRYPTO_DEV_ASPEED_ECDSA is not set | ||
| CONFIG_MODVERSIONS=y |
Contributor
There was a problem hiding this comment.
This is already set by Debian's own default configs, and shouldn't need to be set here.
|
This PR has backport request label(s) for branch(es): 202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202605: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Clean up the
###-> nvidia_aspeed_bmcblock inconfig.local/arm64/config.sonic-aspeed:CONFIG_MODVERSIONSout of the block, since it is a common kernel configCONFIG_MSDOS_FSandCONFIG_FAT_DEFAULT_UTF8These are the changes requested in the review of #609 and merged there on
202605.mastercarries the same block, but never received them.How I did it
How to verify it