program: Deposit / withdraw must be atomic with authorize - #797
Merged
Conversation
#### Problem The `DepositStake` and `WithdrawStake` instructions expect the user to set the authority / approve tokens in the same transaction as the deposit / withdrawal, but it's not explicitly stated. #### Summary of changes Add a comment to both instructions specifying that the authority change / approve instruction must happen in the same transaction, otherwise funds are at risk.
2501babe
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
DepositStakeandWithdrawStakeinstructions expect the user to set the authority / approve tokens in the same transaction as the deposit / withdrawal, but it's not explicitly stated.Summary of changes
Add a comment to both instructions specifying that the authority change / approve instruction must happen in the same transaction, otherwise funds are at risk.