Repository navigation
Add opt-in OIDC role synchronization on login - #346
Open
christopher-svensson-stegra wants to merge 1 commit into
Open
christopher-svensson-stegra wants to merge 1 commit into
christopher-svensson-stegra wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OIDC group mappings already override a user’s role when they match. When the last matching group is removed, the previous role is currently retained. Changing default_role also leaves existing unmatched accounts unchanged.
Add an opt-in setting:
With synchronization enabled, every successful OIDC login applies the highest role mapped from the validated ID token’s groups, or default_role when none match. The stored role does not participate in that decision. A matching viewer mapping still wins over an operator default: the default is a fallback, not a minimum.
Typical uses:
The option defaults to false, preserving existing role-assignment behavior. Role lookup or persistence errors reject the login rather than issuing a session with stale privileges. Reconciliation runs before creating the new auth session; it does not poll the IdP, revalidate on every request, or terminate active remote desktop sessions. Local API-key admins are unaffected.
Includes configuration documentation, examples, and regressions for promotion, demotion, default changes, explicit lower mappings, compatibility mode, and database failures.