Skip to content

Fix Fedora CI build by aligning srpc/tutorial CMake C++ standard with protobuf requirements - #438

Closed
holmes1412 with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-fedora-github-actions-job
Closed

holmes1412 with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-fedora-github-actions-job

Conversation

Copilot AI commented Sep 10, 2026 •

Copy link
Copy Markdown

The Fedora Actions job fails because rawhide’s protobuf headers require C++17 features, while srpc build paths were pinned to C++14. This updates the affected non-Windows CMake flags so Fedora can compile against current protobuf.

  • Root cause addressed

    • Fedora rawhide pulls newer protobuf headers (std::is_same_v, if constexpr) that are incompatible with -std=c++14.
  • Build config updates (minimal scope)

    • src/CMakeLists.txt: non-Windows CMAKE_CXX_FLAGS switched from -std=c++14 to -std=c++17.
    • tutorial/CMakeLists.txt: same non-Windows flag update for tutorial builds.
  • Resulting behavior

    • Keeps existing build flow intact; only raises language level where Fedora compilation was failing.
# before
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fPIC -pipe -std=c++14 -fno-exceptions")

# after
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fPIC -pipe -std=c++17 -fno-exceptions")

Co-authored-by: holmes1412 <1880011+holmes1412@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'fedora' Fix Fedora CI build by aligning srpc/tutorial CMake C++ standard with protobuf requirements Sep 10, 2026
Copilot AI requested a review from holmes1412 September 10, 2026 08:29
@holmes1412 holmes1412 closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants