Fix Fedora CI build by aligning srpc/tutorial CMake C++ standard with protobuf requirements - #438
Closed
holmes1412 with Copilot wants to merge 2 commits into
Closed
holmes1412 with Copilot wants to merge 2 commits into
holmes1412 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: holmes1412 <1880011+holmes1412@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'fedora'
Fix Fedora CI build by aligning srpc/tutorial CMake C++ standard with protobuf requirements
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fedora Actions job fails because rawhide’s protobuf headers require C++17 features, while srpc build paths were pinned to C++14. This updates the affected non-Windows CMake flags so Fedora can compile against current protobuf.
Root cause addressed
std::is_same_v,if constexpr) that are incompatible with-std=c++14.Build config updates (minimal scope)
src/CMakeLists.txt: non-WindowsCMAKE_CXX_FLAGSswitched from-std=c++14to-std=c++17.tutorial/CMakeLists.txt: same non-Windows flag update for tutorial builds.Resulting behavior