ui: truncate long text to terminal width in Select/Prompt templates - #249
Open
mmustafasenoglu wants to merge 1 commit into
Open
ui: truncate long text to terminal width in Select/Prompt templates#249mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
screenbuf assumes each Write() is exactly one terminal line, but when text is wider than the terminal it wraps, causing stale content to remain on screen (issue #466). Add a truncFunc template helper that measures the terminal width via golang.org/x/term and truncates the string so the rendered line stays within bounds. The function is registered in promptui.FuncMap and applied to the default Select and NamedSelect templates (Label, Active, Inactive) with a prefixLen of 4 to account for the page arrow, spacing, and icon characters.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes smallstep/cli#466
When the terminal is narrower than the rendered text, screenbuf still counts each Write as one line. The wrapped content isn't cleared on the next redraw, so stale characters remain visible.
This adds a truncFunc template helper that measures the terminal width and clips the string so the full rendered line (prefix icons + content) stays within bounds. It's registered in promptui.FuncMap and applied to the default Select and NamedSelect templates (Label, Active, Inactive) with a prefixLen of 4 to account for the page arrow, spacing, and icon characters.