Repository navigation
new check exit code - #221
Merged
Merged
Conversation
runTestsInFile called runCode(testFile, ...) twice: once before the try and once inside it. Every tutor check was counted twice, every failure was printed twice, and an exception in the first call bypassed handleCurrentException. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With --check, both a crash while loading and failing checks ended with exit code 1, so the Praktomat checker had to run WYPP a second time with --check-runnable to tell them apart. Failing checks (student and tutor checks together) now give exit code 3 (EXIT_CODE_FAILING_CHECKS in utils.py; not 2, which argparse uses for usage errors). Exit code 1 stays for exceptions while loading the file or running the test file; this now also holds with --interactive, where a crash while loading used to give 0 if no check failed. fileTestsLib.record() now honors exitCode from WYPP_TEST_CONFIG, as check() already did, so file tests expecting exit code 3 can be recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.