Repository navigation
fix: share character mappings with the default export - #222
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require('slugify').extend({'@': 'at-sign'})does not affectrequire('slugify').default('@'): the CommonJS wrapper creates two separate functions and character maps. This also breaks the documented process-wide scope ofextend()when import styles are mixed.Make
defaultreference the existing export. The regression checks extensions in both directions and resets the module cache afterward.Validation: the new regression failed before the fix.
npm testpasses the build and all 46 tests afterward;npm run test:covreports 100% function coverage. Syntax and diff checks pass (Node 24). AMD/browser and older Node versions were not run.