Repository navigation
Conversation
CreateNewLangProj named the empty Anthropology Categories list in the default analysis writing system, found with GetWsFromStr(IcuLocale). GetWsFromStr expects a language tag, so creation threw for a writing system like pt-BR, whose ICU locale is pt_BR. Fixes #416 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
myieye
approved these changes
Nov 19, 2026
myieye
left a comment
Contributor
There was a problem hiding this comment.
Looks safe and solid to me and my robot 🤖
We're now using the same ID that is used by the create on L404=>L748.
That consistency basically speaks for itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #416.
We have this bug when calling Create new project.
AI summary
When
CreateNewLangProjgets no anthropology list file, it names the empty list in the default analysis writing system. It looked that writing system up withGetWsFromStr(analWrtSys.IcuLocale), butGetWsFromStrexpects a language tag. That only works when the two match. Forpt-BR(ICU localept_BR) the lookup returned 0 and project creation threw.This passes
analWrtSys.Id, whichCreateAnalysisWritingSystemalready uses to register the same writing system.Found from LexBox, which creates projects without a list file.
Test plan
LcmCacheTests.CreateNewLangProject_DefaultAnalysisWsWithIcuLocaleDifferentFromTagcreates a project withpt-BRas the default analysis writing system and checks the list is named in it. It fails without the fix and passes with it (net8.0).LcmCacheTests.CreateNewLangProject*tests still pass.🤖 Generated with Claude Code
This change is