Skip to content

Tell Mac FW Lite users when an update is out - #3014

Open
hahn-kev-bot wants to merge 1 commit into
developfrom
fwlite-mac-update-check
Open

hahn-kev-bot wants to merge 1 commit into
developfrom
fwlite-mac-update-check

Conversation

@hahn-kev-bot

Copy link
Copy Markdown
Collaborator

AI summary

Summary

The Mac app now checks for updates the same way Linux does: it asks lexbox, and if a newer release exists it shows the existing "A new version of FieldWorks Lite is available" toast with a Download button that opens the DMG. It still doesn't install the update itself.

 appsettings.json  FwLiteRelease:Editions
   Windows  \.msixbundle$
   Linux    linux\.zip$
   Android  \.apk$
+  Mac      \.dmg$

 UpdateChecker.ShouldCheckReleaseFeed
-  skip feed if Os is iOS or Mac or Android
+  skip feed if Os is iOS or Android

This also makes https://lexbox.org/api/fwlite-release/download-latest?edition=mac work, so the download page can link to it like the other platforms. The FAQ's Mac box now explains the update prompt and the drag-to-Applications step.

Evidence

  • Before (prod today):
    download-latest?edition=mac → 404
    should-update?edition=mac&appVersion=<older> → {"release":null,"update":false}
    (the same request with edition=linux returns the new release)
    After: FwLiteReleaseServiceTests.CanGetLatestRelease(Mac) passes against live GitHub and finds FieldWorksLite.dmg. UpdateCheckerTests (13) and FwLiteReleaseServiceTests (12) pass; Mac moved from the "store-distributed, skip the feed" cases to the "uses the feed" cases.

Merge Danger

Door: two-way

Blast Radius: Mac only

The client half only reaches Mac users once a new release ships. Mac builds already on people's machines skip the feed, so the server half changes nothing for them except making the download link work.

Test plan

  • After deploy, https://lexbox.org/api/fwlite-release/download-latest?edition=mac downloads the DMG
  • On a Mac running an older build from this branch's release, the update toast appears and Download opens the DMG

🤖 Generated with Claude Code

Lexbox now serves the Mac DMG from the release feed (download-latest
and should-update with edition=mac), and the Mac app checks that feed
like Linux does. It can't install the update itself, so it shows the
existing "A new version is available" toast with a Download button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📦 Lexbox issues related to any server side code, fw-headless included labels Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Mac now uses the release feed, subject to throttling. iOS and Android remain excluded unless the update condition is Always. The release configuration and tests now include Mac DMG assets. The FAQ explains how to download and replace the Mac app.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Possibly related PRs

Suggested labels: 💻 FW Lite, 📦 Lexbox

Suggested reviewers: myieye

Merge Risk: Minimal · up to 2e21a

Mac FW Lite will check the release feed and show the existing update toast with a Download button for the DMG. The change is small and reversible by revert, and no concrete defect remains. The post-deploy download and older-build toast checks from the test plan are still worth doing after release.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main user-facing change: Mac FW Lite users are now told when an update is available. The changeset adds the Mac .dmg release edition and stops the update checker from skipping Mac,…
Description check Passed The description explains the change. It says the Mac app now checks the release feed like Linux, shows the update toast with a Download button, and adds the .dmg edition and the UpdateChecker skip-lis…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main user-facing change: Mac FW Lite users are now told when an update is available. The changeset adds the Mac .dmg release edition and stops the update checker from skipping Mac, so the title matches the primary change.

Full details: Description check

Explanation

The description explains the change. It says the Mac app now checks the release feed like Linux, shows the update toast with a Download button, and adds the .dmg edition and the UpdateChecker skip-list change. It also covers the FAQ update and the test evidence, so it relates directly to the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Biome (2.6.5)

backend/LexBoxApi/appsettings.json

File contains syntax errors that prevent linting: Line 52: Expected a property but instead found '// does not effect jwt used for the cookie'.; Line 53: End of file expected; Line 53: End of file expected; Line 53: End of file expected; Line 53: End of file expected; Line 54: End of file expected; Line 54: End of file expected; Line 54: End of file expected; Line 54: End of file expected; Line 55: End of file expected; Line 55: End of file expected; Line 55: End of file expected; Line 55: End of file expected; Line 56: End of file expected; Line 56: End of file expected; Line 56: End of file expected; Line 56: End of file expected; Line 57: End of file expected; Line 57: End of file expected; Line 57: End of file expected; Line 58: End of file expected; Line 59: End of file expected; Line 59: End of file expected; Line 60: Expected a property but instead found '// properties declared in CookieAuthenticationOptions'.; Line 59: End of file expected; Line 60: End of file expecte

... [truncated 1341 characters] ...

; Line 89: End of file expected; Line 91: End of file expected; Line 92: End of file expected; Line 92: End of file expected; Line 93: Expected a property but instead found '// the notarized Mac Catalyst build, FieldWorksLite.dmg'.; Line 92: End of file expected; Line 93: End of file expected; Line 94: End of file expected; Line 94: End of file expected; Line 94: End of file expected; Line 95: End of file expected; Line 98: End of file expected; Line 98: End of file expected; Line 99: Expected a property but instead found '// Enabled is controlled per-environment via Analytics__Enabled: off in the k8s b; Line 98: End of file expected; Line 99: End of file expected; Line 101: End of file expected; Line 101: End of file expected; Line 101: End of file expected; Line 102: End of file expected

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the feed at dawn,
A Mac DMG comes hopping on.
The Download button marks the way,
Then apps swap places for the day.
Projects stay where they belong,
While bunny ears hum update song.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f898aec9-f611-480f-8de6-1042acc124bb
Commits

Reviewing files that changed from the base of the PR and between 0f7e9f7 and 2e21a0c.

Files selected for processing: 6

  • backend/FwLite/FwLiteShared.Tests/AppUpdate/UpdateCheckerTests.cs
  • backend/FwLite/FwLiteShared/AppUpdate/UpdateChecker.cs
  • backend/LexBoxApi/Services/FwLiteReleases/FwLiteReleaseService.cs
  • backend/LexBoxApi/appsettings.json
  • backend/Testing/LexCore/Services/FwLiteReleaseServiceTests.cs
  • docs/site/fw-lite/faq.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants