Skip to content

[claude] Make sync block and unblock admin-only - #3009

Merged
myieye merged 1 commit into
developfrom
admin-only-sync-block
Nov 19, 2026
Merged

myieye merged 1 commit into
developfrom
admin-only-sync-block

Conversation

@myieye

@myieye myieye commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

Block and unblock were admin-only until a77a7c6 moved them to SyncController and, without discussion, let anyone who can sync call them; no UI or client uses them.

🤖 Generated with Claude Code

Both started out [AdminRequired] in ProjectController. a77a7c6 moved them
to SyncController with the "can sync the project" check while fixing project
code resolution, which let any editor block or unblock. No UI or client calls
them, and the API tests already use admin. An editor could otherwise freeze
lexicon writes for everyone, or lift a rollback block before anyone checked it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 425f966c-722c-4ef6-9816-3391b5ffb589
Commits

Reviewing files that changed from the base of the PR and between 322d78d and 2f96440.

Files selected for processing: 3

  • backend/FwHeadless/AGENTS.md
  • backend/LexBoxApi/Controllers/SyncController.cs
  • docs/site/technical/sync/fwheadless-merge.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the 📦 Lexbox issues related to any server side code, fw-headless included label Nov 19, 2026
@myieye myieye added the self-reviewed 👁️ I reviewed this myself and with AI and decided it was safe to merge without a second set of eyes label Nov 19, 2026
@myieye
myieye merged commit 2e728ea into develop Nov 19, 2026
33 checks passed
@myieye
myieye deleted the admin-only-sync-block branch November 19, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 Lexbox issues related to any server side code, fw-headless included self-reviewed 👁️ I reviewed this myself and with AI and decided it was safe to merge without a second set of eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant