Repository navigation
[claude] Ignore blank values in JSON patch adds to rich multi-strings - #3004
Conversation
Older commits store RichMultiString values as plain strings, and the RichString converter reads a blank one as null. The indexer already treats null as removing the writing system; the typed Add, which JSON patch "add" ops use, threw a NullReferenceException instead. That broke snapshot regeneration after a model version bump for any project holding such a commit: fatal in FwHeadless, logged on every open in FW Lite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Possibly related PRs
Suggested reviewers: Merge Risk:
|
[Claude, autonomous]
A legacy patch like
{"op":"add","path":"/Sentence/en","value":" "}madeRichMultiString.Addthrow (the converter reads a blank string as null), which breaks snapshot regeneration after a model version bump: fatal in FwHeadless (ThrowOnModelVersionReconcileFailure), logged on every open in FW Lite.Addnow treats null like the indexer already does. Verified against a copy of an affected production project: it fails to open without the fix and regenerates all ~18k commits with it.🤖 Generated with Claude Code