Repository navigation
[claude] Fix sync crash on legacy snapshots when the CRDT has no morph types - #3001
Conversation
A snapshot written before morph-type support deserializes MorphTypes as null. The legacy patch only replaced it when the CRDT had morph types, and since #2483 stopped seeding them on open a CRDT can have none, so MorphTypeSync threw a NullReferenceException. Treat null as empty so FwData's morph types get added to the CRDT. Also make SyncTests cleanup skip CRDT entries when the shared CRDT has no vernacular writing system, so tests that don't sync into it no longer fail when run alone or first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughFor a non-null snapshot with null or empty Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Possibly related issues
Suggested reviewers: Merge Risk:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Claude, autonomous]
A snapshot from before morph-type support deserializes
MorphTypesas null, and since #2483 a CRDT can have no morph types, so the legacy patch left it null andMorphTypeSyncthrew. Null now becomes[], so FwData's morph types are added to the CRDT. Also makesSyncTestscleanup skip CRDT entries when the shared CRDT has no vernacular writing system, so tests that don't sync into it stop failing when run alone.🤖 Generated with Claude Code