Skip to content

[claude] Test hg 3 clients with FLEx Bridge 4.3's Chorus - #2997

Merged
myieye merged 4 commits into
developfrom
claude/hg3-lane-net11
Nov 19, 2026
Merged

myieye merged 4 commits into
developfrom
claude/hg3-lane-net11

Conversation

@myieye

@myieye myieye commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

The hg 3 lane from #2971 loaded Chorus 5.2 on .NET 11, which fails there: resumable pushes hit the removed BinaryFormatter, and on Windows every hg command read hg's exit code before hg exited. Real hg 3 users run it on .NET Framework, so the release was fine.

The lane now uses the hg 6 lane's Chorus 6.0.0-beta0063 / LfMergeBridge 4.3.0-beta0048 (green on Linux and Windows) with the hg 3 binary. It predates the zstd-v2 bundles hg 3 can't read (sillsdev/chorus#398).

Not verified: hg client tests can't run against staging from a branch, so the next release run or a post-merge dispatch from develop is the check.

🤖 Generated with Claude Code

The hg 3 lane loads Chorus 5.2, a .NET Framework library, on .NET 11:
- Its resumable transport saves state with BinaryFormatter, which .NET 9
  removed. Add the compat package and enable it for that lane only.
- On Windows it reads hg's exit code before hg exits ("Process must exit
  before requested information can be determined") on every hg command.
  That's inside Chorus, so drop the Windows hg 3 lane; Linux hg 3 still
  covers the server side.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The MercurialVersion 3 branch in HgClientTests.csproj now references LfMergeBridge 4.3.0-beta0048 and LibChorus 6.0.0-beta0074, replacing their previous versions. The branch comment now describes the hg 3 compatibility context.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: hahn-kev

Merge Risk: Minimal · up to 13e2b

No merge blocker was found in the hg 3 test-lane update. The planned staging run should still confirm that resumable pushes work on Linux and Windows and that the Windows exit-code error no longer occurs.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names the main change: the hg 3 client-test lane now tests against Chorus and FLEx Bridge 4.3's Chorus. The raw summary confirms the csproj change to LfMergeBridge 4.3.0-beta0048 and LibChor…
Description check Passed The description explains the reason for the change. The hg 3 lane loaded Chorus 5.2 on .NET 11, which failed. The lane now uses the hg 6 lane's Chorus and LfMergeBridge versions. It also states that t…
Full details: Title check

Explanation

The title names the main change: the hg 3 client-test lane now tests against Chorus and FLEx Bridge 4.3's Chorus. The raw summary confirms the csproj change to LfMergeBridge 4.3.0-beta0048 and LibChorus 6.0.0-beta0074 for MercurialVersion 3. The title says 'Chorus' without naming the version. It is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description explains the reason for the change. The hg 3 lane loaded Chorus 5.2 on .NET 11, which failed. The lane now uses the hg 6 lane's Chorus and LfMergeBridge versions. It also states that the change is not yet verified against staging. This matches the csproj change in the summary.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

I’m a rabbit, checking versions in a row,
LfMergeBridge and LibChorus now grow.
The hg 3 branch has a refreshed pair,
I nibble a note and hop through the air.
One happy thump for the packages there!

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b51f0e5a-57c8-49c2-b057-aa3572ae61ab
Commits

Reviewing files that changed from the base of the PR and between 1151690 and 13e2bbe.

Files selected for processing: 1

  • backend/HgClientTests/HgClientTests.csproj

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions github-actions Bot added 📦 Lexbox issues related to any server side code, fw-headless included 🔩 FW Lite Core Shared MiniLcm, CRDT and sync libraries that ship in both FW Lite and FwHeadless labels Nov 18, 2026
Supersedes the previous commit, whose BinaryFormatter shim and dropped
Windows lane are reverted. Chorus 6.0.0-beta0063 already runs on .NET 11
(the hg 6 lane passes on Linux and Windows) and predates the zstd-v2
bundles hg 3 can't read, so the hg 3 lane keeps both OSes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@myieye myieye changed the title [claude] Get the hg 3 client tests running on .NET 11 [claude] Test hg 3 clients with FLEx Bridge 4.3's Chorus Nov 18, 2026
6.0.0-beta0074 with LfMergeBridge 4.3.0-beta0048 is what the hg 3 lane
used until #2942; it is newer than FLEx Bridge 4.3's 6.0.0-beta0063 and
still predates zstd-v2 bundles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@myieye myieye changed the title [claude] Test hg 3 clients with FLEx Bridge 4.3's Chorus [claude] Test hg 3 clients with a pre-zstd Chorus 6 Nov 18, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@myieye myieye changed the title [claude] Test hg 3 clients with a pre-zstd Chorus 6 [claude] Test hg 3 clients with FLEx Bridge 4.3's Chorus Nov 18, 2026
@myieye
myieye merged commit 240f0e6 into develop Nov 19, 2026
26 checks passed
@myieye
myieye deleted the claude/hg3-lane-net11 branch November 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔩 FW Lite Core Shared MiniLcm, CRDT and sync libraries that ship in both FW Lite and FwHeadless 📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants