Repository navigation
Update the Lua notes for require caching, whole-file reads and yearday - #11
Merged
Merged
Conversation
Firmware now caches require, returns the whole file from a bare read, and starts yearday at 1, so the notes no longer warn about the old behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the hand-written
s2-luanotes for siliconwitchery/s2-firmware#92:requireruns a file once and returns the same value on later calls.handle:read()with no options returns the whole file, and raisesnot enough memorywhen it does not fit.yeardayis no longer listed as 0-based.#10 regenerates
lua-api.mdfrom the same docs change.