Repository navigation
fix(scenarios): accept stated timeline descriptions in event labels - #536
Merged
Merged
Conversation
Collaborator
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Sketchi Web PreviewStatus:
|
Contributor
Sketchi Icons PreviewStatus:
|
Contributor
Sketchi Eval Harness PreviewStatus:
|
Contributor
Sketchi Excalidraw Workspace PreviewStatus:
|
Contributor
Sketchi Playground / Studio PreviewStatus:
|
Merge activity
|
…536) ## Summary Accept a stated timeline description in the matched event's label when the label is exactly the event name, a punctuation/newline separator, and the complete description under the existing case/punctuation/whitespace normalization. Keep the existing description-field check unchanged. The shared rule applies to every timeline assertion with a description, not a lunar-specific opt-in. Event identity, distinct matching, dates/order, kind, lane and spans stay unchanged. Missing names, missing/partial/paraphrased text, extra words, and descriptions attached to another event remain failures. No generation prompt, runtime, renderer or UI change. ## Proof - Minimal specs from all five r23 Sonnet samples; the four intended positives fail before the fix and pass after it. The genuine omission in s5 still fails. - 27 description tests and 43 existing timeline tests pass, including matcher negatives and a non-lunar assertion/label-alternative case. - Per-sample r17-r23 retained comparison: **70/70 judge agreement**, up from 66/70. Full deterministic passes **56 → 60**. The only four newly passing samples are r23 Sonnet s1-s4, each labeled `Touchdown: First soft landing near the south pole.` The ten genuine omissions remain failing. - Inspected all 102 eval directories in that window, including every intervening A/B; only the 14 full-round evals contain described-timeline samples (70 total). Also checked all 149 evals referenced by the retained A/B logs (including earlier A/Bs): no additional described-timeline samples. No fresh generation/judging or eval-archive writes. - **493-candidate retained regrade: 403 pass / 90 fail unchanged; 0 newly failing, 0 newly passing, 0 changed failed-check sets.** - Original r23 MCP receipts through the scenario CLI: s1-s4 pass; s5 fails as expected. Private per-sample table, exact newly passing run IDs, baseline/final JSON, input provenance and logs: `.memory/timeline/check-vs-judge.md` and `.memory/timeline/VERIFICATION.md` in the assigned worktree. No private eval metadata or judge payloads committed. ## Local checks All pass: - `mise exec -- pnpm install` - `pnpm nx affected -t typecheck,test,build --base=origin/main` - `pnpm run check` - `pnpm nx build-storybook diagram-ui` - `pnpm nx affected -t test-browser --base=origin/main` (remote Browserbase; no local Chromium) - Five Worker dry-runs after app builds No new preview-page/production or generation-cost claim. Lead owns independent review and merge; no merge performed. ## Handoff state Required CI and all five preview deployments are green at `403e89f0a12bff0aa28455402bf5def688a7558e`. The icons preview passed after one retry of Cloudflare assets-upload-session error `10013`; no source change. Graphite AI Review passed; no open review threads. Independent review and merge remain lead-owned.
graphite-app
Bot
force-pushed
the
fix/timeline-description-in-label
branch
from
October 23, 2026 20:52
403e89f to
677bb2b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept a stated timeline description in the matched event's label when the label is exactly the event name, a punctuation/newline separator, and the complete description under the existing case/punctuation/whitespace normalization. Keep the existing description-field check unchanged.
The shared rule applies to every timeline assertion with a description, not a lunar-specific opt-in. Event identity, distinct matching, dates/order, kind, lane and spans stay unchanged. Missing names, missing/partial/paraphrased text, extra words, and descriptions attached to another event remain failures. No generation prompt, runtime, renderer or UI change.
Proof
Touchdown: First soft landing near the south pole.The ten genuine omissions remain failing.Private per-sample table, exact newly passing run IDs, baseline/final JSON, input provenance and logs:
.memory/timeline/check-vs-judge.mdand.memory/timeline/VERIFICATION.mdin the assigned worktree. No private eval metadata or judge payloads committed.Local checks
All pass:
mise exec -- pnpm installpnpm nx affected -t typecheck,test,build --base=origin/mainpnpm run checkpnpm nx build-storybook diagram-uipnpm nx affected -t test-browser --base=origin/main(remote Browserbase; no local Chromium)No new preview-page/production or generation-cost claim. Lead owns independent review and merge; no merge performed.
Handoff state
Required CI and all five preview deployments are green at
403e89f0a12bff0aa28455402bf5def688a7558e. The icons preview passed after one retry of Cloudflare assets-upload-session error10013; no source change. Graphite AI Review passed; no open review threads. Independent review and merge remain lead-owned.