Repository navigation
Conversation
The Availability Zones scenario creates/removes Nova host aggregates with the
openstack.cloud.host_aggregate module against the admin cloud. Unlike the other
admin openstack operations in the suite (e.g. the project_info lookup in
prepare/tasks/clouds.yml and the cleanup tasks), these three tasks omit the
`verify: "{{ admin_verify_cacert }}"` parameter, so openstacksdk verifies the
admin cloud's self-signed TLS certificate against the system trust store and
fails during prepare:
SSL: CERTIFICATE_VERIFY_FAILED: self-signed certificate in certificate chain
Add `verify: "{{ admin_verify_cacert }}"` to the host_aggregate calls in
configure_az.yml and remove_az.yml, consistent with every other admin cloud
operation in the collection.
Change-Id: I99fd747fddb188f93d08e9f1d2722ab0f076aec9
Signed-off-by: Daniel Lawton <dlawton@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: THIS PR IS NOT READY FOR MERGE.
What
Adds
verify: "{{ admin_verify_cacert }}"to the threeopenstack.cloud.host_aggregatetasks used by the Availability Zonesscenario — one in
prepare/tasks/configure_az.ymland two incleanup/tasks/remove_az.yml.Why
These tasks create/remove Nova host aggregates against the admin cloud with
the openstacksdk module. Unlike every other admin openstack operation in the
collection (e.g. the
project_infolookup inprepare/tasks/clouds.ymlandthe cleanup tasks), they omitted the
verifyparameter. openstacksdk thenfalls back to verifying the admin cloud's TLS certificate against the system
trust store.
On RHOSO the admin cloud uses a self-signed CA and its
clouds.yamlentrycarries no
cacert, so the module fails during prepare:SSL: CERTIFICATE_VERIFY_FAILED: self-signed certificate in certificate chainThis is latent for scenarios that don't drive these modules, but the AZ
scenario hits it immediately when configuring Nova/Cinder availability zones.
Fix
Pass
verify: "{{ admin_verify_cacert }}"on the host_aggregate calls,consistent with how the rest of the collection handles admin cloud operations.
Testing
Verified on a live RHOSO + AZ deployment: with this change the AZ prepare
stage gets past host-aggregate creation and nova/cinder AZ configuration
(previously it failed at
Create one host aggregate per compute hostwith theSSL error above). The run proceeds through the AZ volume-type setup.