Feat/review fixes - #15
Merged
Merged
Conversation
added 2 commits
August 26, 2026 10:13
…ication Review fixes: - build_predicate_feed: archive now defaults to False (archived feeds bloat Postgres); live fixture pins archive=False explicitly - user_exists/group_exists return False on failed requests instead of crashing on error text; group readback helpers raise a clear ValueError - mission API: URL-encode query parameters (create_mission, subscriptions, role, content ops) via the shared _query helper - ConnectionHelper.request raises ValueError for unknown HTTP methods - download_certificate uses the class _unwrap like its siblings - dedupe input-naming rule in submission module docstring CA verification: - Server()/ConnectionHelper accept ca_cert: when given, the server certificate is verified against that CA with hostname checking enabled, while still presenting the client certificate for mTLS; without it, behaviour is unchanged (CERT_NONE, documented in README) - SSL context creation extracted into testable create_client_ssl_context() - document deliberate CERT_NONE default in README - tests: real in-loop TLS handshakes for pinned/foreign CA, constructor pass-through, previously untested methods (226 tests, 98% cov)
…ions Newer OpenSSL (as on GH runners) rejects CAs without a keyUsage extension during X.509 purpose checking; also declare serverAuth EKU on the leaf certificate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.