feat: version-aware User Account Management API for TAK Server 5.8 - #10
Merged
Merged
Conversation
added 2 commits
August 25, 2026 15:35
5.8 relocated the user-management endpoints from /user-management/api to /Marti/api/user-management/api. The wrapper now detects the base path from the server's version string on first use (cached), with an optional user_management_base override on the Server instance and a safe legacy fallback when detection fails. Adds HomeApi.is_ldap_admin() for the new-in-5.8 isLdapAdmin endpoint (returns False on 5.7 where it does not exist, live-guarded). 5 new unit tests covering detection/caching/fallback/override; live tests verify prefix detection on the real 5.7 server.
IN and OUT are from the group's point of view: group_list_in holds groups a user may send into (writer side), group_list_out groups whose traffic they receive (reader side). Fixes reversed readers/writers test fixtures and documents the semantics in all affected docstrings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.8 relocated the user-management endpoints from /user-management/api to /Marti/api/user-management/api. The wrapper now detects the base path from the server's version string on first use (cached), with an optional user_management_base override on the Server instance and a safe legacy fallback when detection fails.
Adds HomeApi.is_ldap_admin() for the new-in-5.8 isLdapAdmin endpoint (returns False on 5.7 where it does not exist, live-guarded).
5 new unit tests covering detection/caching/fallback/override; live tests verify prefix detection on the real 5.7 server.