Skip to content

Complete TODO: Improve import_dependency test with exact assertions - #158

Open
kdomi18 wants to merge 1 commit into
se2p:mainfrom
kdomi18:improve-import-dep-test
Open

kdomi18 wants to merge 1 commit into
se2p:mainfrom
kdomi18:improve-import-dep-test

Conversation

@kdomi18

@kdomi18 kdomi18 commented Oct 28, 2026

Copy link
Copy Markdown

This commit improves an old import dependency test with exact assertions. Instead of importing the full asteroid module we import only Constant and a simple function is added to the class provided by the dependency so a modifier can be constructed from it.

@LuKrO2011

Copy link
Copy Markdown
Member

Now there is a new TODO instead:

TODO check if The numbers of the following values change depending on whether we run the test from PyCharm or from the command line

@kdomi18

kdomi18 commented Oct 29, 2026

Copy link
Copy Markdown
Author

Yes, because I didn't have PyCharm installed and the previous TODO specifically mentioned it.

@LuKrO2011

Copy link
Copy Markdown
Member

I don't see the benefit of resolving one TODO while adding another.
Additionally, merging your changes might introduce a flaky test, which we should avoid.
To resolve the original TODO one should IMO look if the issue is reproducible and debug it first.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants