Repository navigation
fix: accept any Sentry integration in sentry.integrations (2.4.1) - #22
Merged
Merged
Conversation
The integrations type was derived from expressIntegration's return type. Since Sentry 10.7x each integration's type carries its literal name, so passing httpIntegration() fails to type-check. Derive the type from NodeOptions['integrations'] instead. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryConfig.integrationswas typed asReturnType<typeof Sentry.expressIntegration>[]. Since Sentry 10.7x, each integration's type includes its literalname, so agentic-api'shttpIntegration()no longer type-checks:The type is now derived from
NodeOptions['integrations'], so any Sentry integration is accepted.Integrationis only exported from@sentry/core, which isn't a direct dependency, hence the derived type.This blocks the agentic-api bump to observability-js 2.4.x.
Test plan
httpIntegration(). With the old type it failsnpm run typecheck; with the fix it passes.npm run build && npm run typecheck && npm run lint && npm test(58 passing)releaseworkflow; agentic-api moves to 2.4.1🤖 Generated with Claude Code