Repository navigation
fix: name editions sensibly when the library gives a placeholder name - #41
Open
scooper4711 wants to merge 1 commit into
Open
scooper4711 wants to merge 1 commit into
scooper4711 wants to merge 1 commit into
Conversation
Some entries carry a placeholder name such as "Test" or "Accidental duplicate package - disregard" while their file is the real book. Such an edition now takes the name of a properly named edition of the same kind, with its update date added, or else a name built from the product name, so its label and file name make sense. Closes #40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some entries carry a placeholder name such as "Test" or "Accidental duplicate package - disregard" while their file is the real book. Such an edition now takes the name of a properly named edition of the same kind, with its update date added, or else a name built from the product name, so its label and file name make sense.
Changes:
PlaceholderNamesto detect placeholder edition names.EntitlementGrouperreplaces a placeholder name with the name of a properly named edition of the same kind (plus its update date), falling back to a name built from the product name.Closes #40