Repository navigation
0.16.0: the Replay view opens at the game's scale; grid, locations, fog and pointer carry over - #16
Merged
Merged
Conversation
The Replay view opened at the map's 100% — as many rows of the map as the frame is tall — which on a tall frame is well zoomed out from the game. It now opens at the game's 480 rows across the frame's height, on the first player's start. Switching between the map and the replay still keeps the scale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he Replay view The game is drawn under the editor's grid, the map's locations and the other plugins' overlays (MapViewHandle.paintOver, redrawn on onRepaint), below Aftermath's own marks and not in the cinematic view. View ▸ Fog of War is the game's fog: on is a player's eyes (the last chosen, the first player at first), off is everyone's, and the toggle shows what the Vision menu says (setFog). The pointer's map pixel from scm-sim 0.10.0 goes to the editor's status bar. Needs plugin-api 1.54 for the types; works with older editors and play pages, which leave each piece out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opens at the game's scale. A replay used to open at the map's 100%, as many rows of the map as the frame is tall, which is well zoomed out from the game on a tall frame. It now opens at the game's own 480 rows. Switching Map ⇄ Replay still keeps the scale.
Carries the editor's view over to the game (scm-js/scm-js#52):
paintOver, redrawn ononRepaint). They are not drawn in the cinematic view.onFog/setFog).setPointer, from plugin-scm-sim 0.10.0).Each piece is left out with an older editor or play page.
plugin-api: the devDependency is now ^1.54.0 (published from scm-js#52), so CI's typecheck has the new calls.
Testing: a new Game view test (fog,
paintOver, pointer), and the opening test now expects 480 rows. All 123 tests and the typecheck pass against plugin-api 1.54.0. Checked end to end in a built editor with a replay: opens at 133%, grid over the game, Fog ⇄ Vision both ways, the pointer in the status bar. Rebased onto 0.15.1 (seek-stall).Known, not from this change: choosing a player's eyes at 0:00 shows black until the game runs. The Vision menu does the same.
🤖 Generated with Claude Code