Repository navigation
0.15.1: a jump in the Game view never hangs on "Going to…" - #15
Merged
Merged
Conversation
Two seeks still waited for good. One aimed past where the game stops (the engine ends short of the replay for some replays): the viewer kept saying it was on its way, so the give-up never ran. It now settles where the game stopped once the seek's progress has not moved for four seconds. The other landed while playing and played on past the mark before the viewer said it was over: frames kept coming, so the wait for a quiet second never ended. Playing, the latest frame is now taken once the seek has had its 2.5 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more ways a jump in the Game view could hang on "Going to…", after the 0.13.2 fix:
A long seek that is still moving is waited on as before.
jeany55/scm-sim#16 makes the play page say case 1 is over right away. This PR works without it, after the 4 s wait.
Four new tests in
tests/gameview.test.ts; the two hang cases fail on the old code. Type-check, all 140 tests and the build pass.🤖 Generated with Claude Code