Repository navigation
0.15.0: the editor's zoom works on the Replay view - #14
Merged
Merged
Conversation
View ▸ Zoom In/Out, the levels, Zoom to Fit, the toolbar's buttons, their keys and Ctrl+wheel over the game zoom the Replay view, and the zoom carries over between Map and Replay both ways. Spectate's camera track is made again at the new scale in the same moment, so following goes on without a jump. Needs scm-js's map view zoom (MapViewSpec.onZoom, MapViewHandle.wheel) and, for the wheel and zooming out past twice the game's view, scm-sim 0.9.0's play page. An older editor or page keeps working without them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These all zoom the Replay view now:
The zoom also carries over between Map and Replay both ways. Spectate's camera track is made again at the new scale in the same moment, so following goes on without a jump.
Needs: scm-js/scm-js#50 (merged) and @scm-js/plugin-api 1.53.0, the devDependency now. The wheel and zooming out past twice the game's view also need scm-sim 0.9.0's play page. An older editor or page keeps working without them. Draft until the scm-sim side is out, per the release order.
Testing: 136 tests (two new in
tests/gameview.test.ts) pass, and tsc is clean against the published plugin-api 1.53.0. Checked end to end headless in the editor:dist/plugin.jsis left to CI.🤖 Generated with Claude Code