Repository navigation
fix: Context.children is list[AsyncResult[Any]], not list[str] - #232
Merged
kodiakhq[bot] merged 1 commit intoAug 28, 2026
Merged
Conversation
Sanjays2402
added a commit
to Sanjays2402/celery-types
that referenced
this pull request
Sep 10, 2026
Keeps both appended regression tests in tests/test_celery.py: the Context.children assertion from sbdchd#232 and test_async_result_as_list from this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task.add_trail()appends the actual result object (GroupResult/AsyncResultorEagerResultin eager mode) toContext.children, not the string task ID.see
celery/app/task.py::Task.add_trailand its caller incelery/canvas.py.This matches how
AsyncResult.childrenis already typed inresult.pyi.Added a regression test asserting the type via
self.request.childrenin a bound task. Verified withmypy --strict tests/test_celery.py