Repository navigation
feat(amqp10): implement ClientExists - #236
Merged
sharathb5 merged 9 commits intoOct 7, 2026
Merged
Conversation
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
sharathb5
changed the base branch from
main
to
191-declareexchange-review-followup
October 6, 2026 20:19
sharathb5
marked this pull request as ready for review
October 7, 2026 15:29
sharathb5
requested review from
bithckr,
dhunt3800,
dlawregiets and
rsperl
as code owners
October 7, 2026 15:29
sharathb5
changed the title
bithckr
approved these changes
Oct 7, 2026
Base automatically changed from
191-declareexchange-review-followup
to
feature-amqp10
October 7, 2026 17:03
rsperl
reviewed
Oct 7, 2026
| case provider.CONNECTED, provider.CONNECTING: | ||
| return true | ||
| default: | ||
| // Issue 201: broker-level verification remains unresolved. |
Contributor
There was a problem hiding this comment.
This pr addresses issue 201, right?
Contributor
Author
There was a problem hiding this comment.
yeah the comment was misleading, the PR does use local connection state, like how you mentioned with AMQP 0.9.1. CONNECTED and CONNECTING return true; closed, disconnected, or missing clients return false. The AMQP 1.0 client does not support broker-wide connection lookup.
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
rsperl
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement local AMQP 1.0
ClientExistsstate checks.CONNECTEDandCONNECTINGclients are active; closed, disconnected, missing, and invalid entries are inactive. Broker-level verification remains unresolved due to the pinned AMQP client API.