Repository navigation
Release 1.7.1 - #40
Merged
Merged
Conversation
RLC (HL) and RRC (HL) wrote the unmasked result back to memory, so a byte grew by up to seven bits on every rotation. CRuby kept running with the larger Integer, but the Spinel browser build raised RangeError once the value no longer fit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RangeError: integer overflow in <<.The benchmark ROM never executes these two instructions, so the benchmark results and checksums do not change.
Test plan
bundle exec rake(119 examples, no RuboCop offenses)frontend.cjs,ruby_wasm.mjs,spinel.mjsrubyboy-benchprints the same checksum as 1.7.0 on CRuby, YJIT and Spinel🤖 Generated with Claude Code