Repository navigation
feat: add UniFi Dream Machine (UDM/UDR) device support - #8
Merged
Merged
Conversation
UDM/UDR devices use different API paths than legacy UniFi Controller:
- Login: /api/auth/login (vs /api/login)
- Port forwards: /proxy/network/api/s/{site}/rest/portforward
Changes:
- Add DeviceType field to Client struct with "standard" and "udm" options
- Add path helper methods for dynamic endpoint construction
- Parse ROUTER_DEVICE_TYPE env var in manager (accepts "udm" or "udr")
- Update Helm chart with deviceType configuration
- Add comprehensive tests for UDM paths
Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceTypeconfiguration to support UDM/UDR devices which use different API paths/api/auth/login(vs/api/loginfor standard)/proxy/network/api/s/{site}/rest/portforward(vs/api/s/{site}/rest/portforward)Changes
pkg/unifi/client.go: Add DeviceType type and path helper methodscmd/manager/main.go: Parse ROUTER_DEVICE_TYPE environment variablepkg/unifi/client_test.go: Add 7 new tests for UDM path functionalityrouter.deviceTypeconfiguration optionUsage
For UDM/UDR devices:
Test plan
make test)make helm-test)Closes #7