Repository navigation
Conversation
- 29 hand-rolled buttons become <Button>; the hero actions (train, train again, create, download the engine) use the brand accent. - Stock emerald/amber/sky/red become success/warning/info/destructive, ported here from @nexis/design (the theme's ANSI roles). - ▶ and ⤓ glyphs become icons. - Motion: the body plays the view entrance when its phase changes, charts fade in when the run in view changes, setup and create cards rise in, a live run scans (RunLive), a finished result lands once, and the indeterminate bar sweeps instead of pulsing. - globals.css gains the app-shell, view and content entrances, kept in step with @nexis/design, which is bumped to 0faf638. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at bringing the ML Lab closer to Epoch's look and feel.
Components and colour
<Button>. The hero actions (Train model, Train again, Create, download the engine) use thebrandvariant; the rest usedefaultoroutline.emerald/amber/sky/redbecomesuccess/warning/info/destructive, so they follow all 22 themes. Those tones are ported intoglobals.cssfrom @nexis/design, where they are the theme's ANSI green, yellow and blue.<Icon>s.Motion (all off under reduced motion)
nexis-scene-enter).nexis-run-live); a finished result lands once (nexis-result-arrival).nexis-shimmer) instead ofanimate-pulse.globals.cssgains the app-shell, view and content entrances, kept in step with Upstream Epoch's shell entrances and docking theme nexis-design#5.@nexis/designis pinned to0faf638.Checks
tsc --noEmitpasses, and the ML Lab and style tests pass (234/234).--success.Not included:
pnpm installadded a placeholderallowBuildsentry for the embedded Epoch package topnpm-workspace.yaml. I left it out because it's an approval decision for you. Nexis still pins Epoch ate03b852; bump it after rwetz/nexis-epoch'sdesign-epoch-lookmerges.Before merging: merge rwetz/nexis-design#5, then re-pin to its merge commit on
main.🤖 Generated with Claude Code