Repository navigation
Add advisory for stack_collections - #3246
Merged
LawnGnome merged 3 commits intoSep 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
Links to upstream issue(s) or PR(s)
Severity
StackVec::retaincommitted its new length only after its internal loopcompleted. If the retain predicate or a removed element's
Droppanickedbefore the loop finished, unwinding proceeded with the vector's length
still equal to the original length, leaving either a duplicated or an
already-destroyed element inside
0..len.StackVec's ownDropthenrevisited that slot, causing a double-drop - and for any
Towning aheap allocation or other resource, a double-free.
Requires
T: Dropwith a predicate or destructor capable of panicking,on builds with unwinding enabled (
panic = "unwind"); not exploitableunder
panic = "abort".I am the maintainer of stack_collections; this advisory is self-filed
following the fix merged in the linked PR.
Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date