Repository navigation
Conversation
Justin's tag probe (#402) showed GITHUB_TOKEN gets a 403 tagging the 1.21.1 release commit but a 201 tagging the v1.21.0 commit. The response accepts contents+workflows, and #395 changed a workflow file since v1.21.0. GITHUB_TOKEN can never hold workflows, so switch back to the release app and request contents, pull-requests and workflows. issues is dropped: the app doesn't have it and release-please's PR labels and comments work with pull-requests.
deanq
requested review from
KAJdev,
OneAsterisk and
justinwlin
and
a balanced review from Copilot
and removed request for
OneAsterisk
October 30, 2026 20:44
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
An organization owner must confirm the release app installation has Workflows write permission, an external prerequisite for token creation and the release pipeline that cannot be verified from the diff.
No open issues 🎉
What changed in this PR
Restores GitHub App authentication for Release Please so it can tag releases that include workflow changes. Merging depends on an organization owner first granting the release app Workflows: Read and write.
Changes:
- Generates an app token requesting write access to contents, pull requests, and workflows, without requesting issues access.
- Passes the app token to Release Please instead of
GITHUB_TOKEN.
| File | Description |
|---|---|
.github/workflows/release-please.yml |
Adds app-token generation and uses it for Release Please authentication. |
Review effort: Balanced
Member
Author
|
Not needed: 1.21.1 released with GITHUB_TOKEN. The 403 came from tagging a commit no ref pointed at (main had moved past it), which GitHub gates behind the workflows permission. A temporary branch at 50e819a let release-please tag it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge only after an org owner grants the
runpod-release-pleaseapp Workflows: Read and write. Without the grant, the token step fails withThe permissions requested are not granted to this installation.Why
Justin's tag probe (#402) used
GITHUB_TOKENon the allowlisted Blacksmith runner:#395 changed
.github/workflows/after v1.21.0, so creating the v1.21.1 tag needsworkflows: write.GITHUB_TOKEN(#401) can never have that permission, so release-please fails atcreateRelease. The runner and the IP allow list are not the cause.Change
contents,pull-requestsandworkflowswrite.issuesis not requested: the app doesn't have it, and release-please adds labels and comments to the release PR throughpull-requests.After the grant and merge
The push to main runs Release. release-please tags v1.21.1 at
50e819a, creates the release, and PyPI Publish runs onrunpod-4vCPU-ubuntu-2404.Test plan
make quality-checkpasses locally🤖 Generated with Claude Code