Repository navigation
test(ci): log test app requests to the CI artifacts - #340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On CI, every request to the test app is now logged to
/tmp/cuprite/test_app.log, which is uploaded with the other artifacts when a job fails.This is for investigating a flaky failure:
#dismiss_confirm should return the message presentedon Ruby 3.1 (run). The CDP log in that run's artifacts shows Chrome failing to load/test.jswithnet::ERR_INVALID_HTTP_RESPONSE, whilejquery.jsandjquery-ui.js, requested at the same moment, came back 200. Withouttest.js, the "Open confirm" handler is never attached, soconfirm()never runs and the spec raisesCapybara::ModalNotFound. Puma logged no error at the time.The request log will show whether the failing request reached the app and what it returned, i.e. whether the broken response comes from the app or from Puma's connection handling.